mirror
/
qutebrowser
mirror of https://github.com/qutebrowser/qutebrowser.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
23,514 Commits 48 Branches 99 Tags 86 MiB
Commit Graph

23514 Commits

Author SHA1 Message Date
Florian Bruhin 2cb20dbf5b Skip test broken on QtWebKit 
(cherry picked from commit d01dd9be07bd1591b1ecda298a2bf84b41ea280c)
 2022-06-13 21:46:49 +02:00
Florian Bruhin cd1be710de Fix lint with FindFlags change 2022-06-13 19:37:05 +02:00
Florian Bruhin f81bc8a53f Fix prev_result/next_result with None callbacks 2022-06-13 18:40:08 +02:00
Florian Bruhin bf045f7ec7 Add a helper dataclass for find flags 
When e.g. doing:
- '?foo' (search with reverse=True -> FindBackwards)
- 'N' (prev_result -> no FindBackwards)
- 'n' (next_result -> FindBackwards again)

we need to take a copy of the flags so that we can temporarily clear
FindBackwards when pressing 'N'.

Relevant history:

- We originally did int(self._flags) in
  d450257485.
- In f0da508c21, we used
  QWebPage.FindFlags(int(self._flags)) instead.
- With 97bdcb8e674c8ff27ab92448effef263880ab3aa (picked from
  c349fbd180) we instead do:
  flags = QWebEnginePage.FindFlag(self._flags)

Using FindFlag instead of FindFlags seemed to work fine with PyQt6 and
enum.Flag. With PyQt5, however, later clearing a flag bit ends up with us
getting 0 as an integer, thus losing the type information about this being a
FindFlag instance, and resulting in a TypeError when calling into Qt.

We could use FindFlags() with PyQt 6 but FindFlag() with PyQt 5 to copy the
original flags, but that's getting rather cumbersome. Instead, let's have a
helper dataclass of bools, do away with the bit-twiddling, and only convert it
to a Qt flags when we actually need them. This solves the copying issue nicely,
and also makes the code a lot nicer.

Finally, this also adds a test case which fails when the flags are mutated in
place instead of copied.

We could do the same kind of change for QtWebKit as well, but given that it's
somewhat dead - and perhaps more importantly, won't run with Qt 6 - let's not
bother. To not break the end2end tests with QtWebKit, the output still is the
same as before.

(cherry picked from commit 96a0cc39512753445bc7a01b218b2f1290819ddd)
 2022-06-13 18:40:08 +02:00
Florian Bruhin e15bda307e search: Split navigation/search callbacks 
This way, we can move more logic (checking wrapping, etc.) into the API,
thus making the commands much more simple and stateless.
 2022-06-13 18:40:08 +02:00
Florian Bruhin 8ed08eb213 search: Move wrap argument to next/prev_result 
The fact that we need to specify this while searching rather than when
"zapping" through the results make no sense. It makes both the API as
well as our own code more complex.
 2022-06-13 18:05:37 +02:00
Florian Bruhin f326e0d969 Get rid of _WebEngineSearchWrapHandler 2022-06-13 18:05:37 +02:00
Florian Bruhin 265b018c17 Add a SearchMatch helper class 2022-06-13 18:05:37 +02:00
Florian Bruhin 583354d524 Merge remote-tracking branch 'origin/pr/6670' into dev 2022-06-13 15:47:31 +02:00
Florian Bruhin 06587ea43a Fix lint 2022-06-13 15:01:09 +02:00
Florian Bruhin c4fb367c6e click-element: Fix typing 2022-06-13 14:51:16 +02:00
Florian Bruhin f8433aa85a click-element: Unpack lambda dict into if 
Easier to do assertions, and seems cleaner than storing lambdas.
 2022-06-13 14:47:06 +02:00
Florian Bruhin f4e899e2af Add setting reference 2022-06-13 14:42:54 +02:00
Florian Bruhin fc17602f79 Add test for using :prompt-fileselect-external on wrong prompt 2022-06-13 14:37:27 +02:00
Florian Bruhin 581b665653 Update docs 2022-06-13 14:29:03 +02:00
Florian Bruhin 435e880477 Fix test 2022-06-13 14:25:03 +02:00
Florian Bruhin fe2a5529e6 Merge remote-tracking branch 'origin/pr/7003' 2022-06-13 14:06:51 +02:00
Florian Bruhin 525cdd3478 Update docs 2022-06-13 13:20:04 +02:00
Florian Bruhin ce27831740 Merge remote-tracking branch 'origin/pr/6448' 2022-06-13 13:15:27 +02:00
Florian Bruhin 803866666f Update changelog 2022-06-13 12:40:14 +02:00
Florian Bruhin d45e35d581 Minor fixes 2022-06-13 12:37:50 +02:00
Florian Bruhin 85b867fe8d Merge remote-tracking branch 'origin/pr/7096' 2022-06-13 12:34:33 +02:00
Florian Bruhin c97257cac0 Update changelog 2022-06-13 12:26:01 +02:00
Florian Bruhin 8c887bdba3 Merge remote-tracking branch 'origin/pr/7124' 2022-06-13 12:24:16 +02:00
Florian Bruhin 7ff0bdb6e2 Update changelog 2022-06-13 11:28:32 +02:00
Florian Bruhin 870fccb366 Merge remote-tracking branch 'origin/pr/7196' 2022-06-13 11:26:43 +02:00
Florian Bruhin 609a862e01 Update changelog 2022-06-13 11:20:16 +02:00
Florian Bruhin 91d01f1393 Merge remote-tracking branch 'origin/pr/7168' 2022-06-13 11:19:46 +02:00
Florian Bruhin dc673b89a0 Update changelog URLs 2022-06-13 10:29:35 +02:00
Florian Bruhin 1887635d1b Merge remote-tracking branch 'origin/update-dependencies' 2022-06-13 10:28:57 +02:00
Jimmy 0aa31ef120 Update docs 2022-06-13 19:21:02 +12:00
Jimmy 07fa7d4b13 Merge pull request #7241 from emanuele6/doc 
asciidoc2html.py: also install qute://install.html and qute://stacktrace.html
 2022-06-13 18:57:06 +12:00
qutebrowser bot 29bcae5409 Update dependencies 2022-06-13 04:32:43 +00:00
Emanuele Torre 51ab91c1aa asciidoc2html.py: also install qute://{install,stacktrace}.html 
Closes #6900
 2022-06-10 20:20:53 +02:00
Florian Bruhin 153f52d3aa Simplify callback default 2022-06-08 16:06:27 +02:00
Florian Bruhin 6c99fe7b30 pylint: Ignore new false-positives 2022-06-08 12:43:09 +02:00
Florian Bruhin 6c4e281028 pylint: Fix new unnecessary-lambda-assignment 2022-06-08 12:25:12 +02:00
Florian Bruhin 6347d71d5c pylint: Remove outdated disables 
Looks like 2.14 added bad-option-value:
https://pylint.pycqa.org/en/latest/whatsnew/2/2.14/full.html

locally-enabled is long gone:
https://github.com/PyCQA/pylint/issues/2442

and so is bad-continuation:
https://github.com/PyCQA/pylint/pull/3571

no-self-use was moved to an extension in this release:
https://github.com/PyCQA/pylint/pull/6448
 2022-06-08 12:02:12 +02:00
Florian Bruhin 5aa89662e3 Update changelog URLs 2022-06-08 11:56:39 +02:00
qutebrowser bot 066bc4fe1c Update dependencies 2022-06-06 04:26:30 +00:00
toofar 2091459f01
Merge pull request #7224 from rien333/patch-1 
[readability-js] Remove superfluous css

Using the GH UI this time because I don't think this needs a changelog entry 🤞
 2022-06-05 16:40:52 +12:00
Rijnder Wever 12fcff9fe8
Remove superfluous css 
It makes no sense to force text to be white, especially for users that already use a white background. I probably included this line by mistake.
 2022-06-03 16:46:05 +02:00
Florian Bruhin 95e3c7f966
Merge pull request #7219 from possibilities/update-docs-for-debian 
Update docs for debian, include `libasound`
 2022-05-31 14:27:17 +02:00
Mike Bannister 74c92e19a7 Show dependency list for Buster venv installs 2022-05-31 08:25:33 -04:00
Mike Bannister 30ea708d57 Add `libasound-dev` to venv on debian docs 2022-05-31 08:24:52 -04:00
Florian Bruhin 60f1b7d396 Update changelog 2022-05-30 17:02:08 +02:00
Florian Bruhin 3d953009ba Respect input.insert_mode.auto_enter for inspector 
Fixes #7165
 2022-05-30 17:01:23 +02:00
Florian Bruhin 9b840e22bc Avoid new mypy false-positive 2022-05-30 10:10:23 +02:00
qutebrowser bot d66dc0141c Update dependencies 2022-05-30 04:29:05 +00:00
Florian Bruhin a5c67bbf3f Update changelog 2022-05-28 10:38:54 +02:00