mirror
/
qutebrowser
mirror of https://github.com/qutebrowser/qutebrowser.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix lint with FindFlags change

This commit is contained in:
Florian Bruhin 2022-06-13 19:37:05 +02:00
parent f81bc8a53f
commit cd1be710de
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
qutebrowser/browser/webengine/webenginetab.py
View File

@ -105,11 +105,13 @@ class _FindFlags:
def to_qt(self):
"""Convert flags into Qt flags."""
# FIXME:mypy Those should be correct, reevaluate with PyQt6-stubs
flags = QWebEnginePage.FindFlag(0)
if self.case_sensitive:
flags |= QWebEnginePage.FindFlag.FindCaseSensitively
flags |= ( # type: ignore[assignment]
QWebEnginePage.FindFlag.FindCaseSensitively)
if self.backward:
flags |= QWebEnginePage.FindFlag.FindBackward
flags |= QWebEnginePage.FindFlag.FindBackward # type: ignore[assignment]
return flags
def __bool__(self):

3
tests/unit/browser/webengine/test_webenginetab.py
View File

@ -219,7 +219,8 @@ def test_notification_permission_workaround():
class TestFindFlags:
@pytest.mark.parametrize("case_sensitive, backward, expected", [
(True, True, QWebEnginePage.FindFlag.FindCaseSensitively | QWebEnginePage.FindFlag.FindBackward),
(True, True, (QWebEnginePage.FindFlag.FindCaseSensitively |
QWebEnginePage.FindFlag.FindBackward)),
(True, False, QWebEnginePage.FindFlag.FindCaseSensitively),
(False, True, QWebEnginePage.FindFlag.FindBackward),
(False, False, QWebEnginePage.FindFlag(0)),