hide domainsDashboard for WebPageTest for now (and keep it under new namespace)

This commit is contained in:
soulgalore 2018-01-11 13:58:59 +01:00
parent ddab2d1748
commit 88889435ee
3 changed files with 3 additions and 11 deletions

View File

@ -137,5 +137,4 @@ docker run --shm-size=1g --rm -v "$(pwd)":/sitespeed.io sitespeedio/sitespeed.io
If you use the grafana dashboards, you will notice that by default some of them can be empty. You must set to true two options
* `webpagetest.timeline` : It activates chrome tracing, if you're running chrome. It contains super useful metrics like the Navigation Timing API and chrome specific metrics like FirstMeaningfulPaint.
* `webpagetest.domainsDashboard` : to have the "3rd party vs 1st party" dashboard populated. It will record weight and requests so it will take more disk space in the graphite docker machine.

View File

@ -487,12 +487,6 @@ module.exports.parseCommandLine = function parseCommandLine() {
default: false,
group: 'WebPageTest'
})
.option('webpagetest.domainsDashboard', {
describe: 'Will populate the domains dashboard but take more disk',
type: 'boolean',
default: false,
group: 'WebPageTest'
})
/**
Slack options
*/

View File

@ -82,8 +82,7 @@ const defaultConfig = {
private: true,
aftRenderingTime: true,
video: true,
timeline: false,
domainsDashboard: false
timeline: false
};
function isPublicWptHost(address) {
@ -107,8 +106,8 @@ module.exports = {
this.options = merge({}, defaultConfig, options.webpagetest);
if (this.options.domainsDashboard) {
// that adds a lot of disk space need into graphite, so it's better optional
if (get(this.options, 'ssio.domainsDashboard')) {
// that adds a lot of disk space need into graphite, so we keep it hidden for now
DEFAULT_PAGE_SUMMARY_METRICS.push(
'data.median.firstView.domains.*.bytes',
'data.median.firstView.domains.*.requests'