From 88889435ee590c810ef6fd7db911da5a6d68bfb2 Mon Sep 17 00:00:00 2001
From: soulgalore <peter@soulgalore.com>
Date: Thu, 11 Jan 2018 13:58:59 +0100
Subject: [PATCH] hide domainsDashboard for WebPageTest for now (and keep it
 under new namespace)

---
 docs/documentation/sitespeed.io/webpagetest/index.md | 1 -
 lib/cli/cli.js                                       | 6 ------
 lib/plugins/webpagetest/index.js                     | 7 +++----
 3 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/docs/documentation/sitespeed.io/webpagetest/index.md b/docs/documentation/sitespeed.io/webpagetest/index.md
index 221eced64..e93de74a5 100644
--- a/docs/documentation/sitespeed.io/webpagetest/index.md
+++ b/docs/documentation/sitespeed.io/webpagetest/index.md
@@ -137,5 +137,4 @@ docker run --shm-size=1g --rm -v "$(pwd)":/sitespeed.io sitespeedio/sitespeed.io
 If you use the grafana dashboards, you will notice that by default some of them can be empty. You must set to true two options
 
 * `webpagetest.timeline` : It activates chrome tracing, if you're running chrome. It contains super useful metrics like the Navigation Timing API and chrome specific metrics like FirstMeaningfulPaint.
-* `webpagetest.domainsDashboard` : to have the "3rd party vs 1st party" dashboard populated. It will record weight and requests so it will take more disk space in the graphite docker machine.
 
diff --git a/lib/cli/cli.js b/lib/cli/cli.js
index c6e2cde42..9568c7325 100644
--- a/lib/cli/cli.js
+++ b/lib/cli/cli.js
@@ -487,12 +487,6 @@ module.exports.parseCommandLine = function parseCommandLine() {
       default: false,
       group: 'WebPageTest'
     })
-    .option('webpagetest.domainsDashboard', {
-      describe: 'Will populate the domains dashboard but take more disk',
-      type: 'boolean',
-      default: false,
-      group: 'WebPageTest'
-    })
     /**
      Slack options
      */
diff --git a/lib/plugins/webpagetest/index.js b/lib/plugins/webpagetest/index.js
index 10550f7b3..e13b6b921 100644
--- a/lib/plugins/webpagetest/index.js
+++ b/lib/plugins/webpagetest/index.js
@@ -82,8 +82,7 @@ const defaultConfig = {
   private: true,
   aftRenderingTime: true,
   video: true,
-  timeline: false,
-  domainsDashboard: false
+  timeline: false
 };
 
 function isPublicWptHost(address) {
@@ -107,8 +106,8 @@ module.exports = {
 
     this.options = merge({}, defaultConfig, options.webpagetest);
 
-    if (this.options.domainsDashboard) {
-      // that adds a lot of disk space need into graphite, so it's better optional
+    if (get(this.options, 'ssio.domainsDashboard')) {
+      // that adds a lot of disk space need into graphite, so we keep it hidden for now
       DEFAULT_PAGE_SUMMARY_METRICS.push(
         'data.median.firstView.domains.*.bytes',
         'data.median.firstView.domains.*.requests'