Commit Graph

19950 Commits

Author SHA1 Message Date
Florian Bruhin b300a5464f Point to GitHub discussions feature 2020-06-17 09:34:12 +02:00
Florian Bruhin af3f088a8f Use 0600 mode for uerscript FIFO
os.mkfifo uses mode 0666 masked with the umask, i.e. 0644 on most systems by
default. We'd like things to be more restrictive, to make sure other users
can't get any data from another users' userscript FIFO.

This shouldn't make any difference in practice because the FIFO is in
standarddir.runtime() which must have 0700 permissions (and qutebrowser creates
all standarddir directories with 0700 permissions if they don't exist).

However, it's still a good idea to restrict the permissions as a second line of
defense.
2020-06-16 19:10:21 +02:00
Florian Bruhin a38620a0f9 userscripts: Clear self._filepath on OSError
As an additional precaution that a "tainted" path isn't being used anywhere.
See https://github.com/qutebrowser/qutebrowser/security/code-scanning/2
2020-06-16 18:55:25 +02:00
Florian Bruhin ed227b052b Fix test_urlmarks.py 2020-06-16 18:49:25 +02:00
Florian Bruhin 0e02c910b2 Update changelog 2020-06-16 17:44:20 +02:00
Florian Bruhin ef0482cabb Update tests/manual/mouse.html 2020-06-16 17:37:30 +02:00
Florian Bruhin 3c7f3cb9b4 Merge remote-tracking branch 'origin/pr/5502' 2020-06-16 17:35:40 +02:00
Florian Bruhin 06e23f44f8 tests: Stabilize test_qute_settings_persistence for real
Before, the "Config option changed: *" triggered on:

  Config option changed: content.headers.user_agent = ...

https://github.com/qutebrowser/qutebrowser/issues/5390#issuecomment-628773737
2020-06-16 17:30:42 +02:00
Florian Bruhin 2e12ba21af Improve QtWebKit/QtWebEngine import checks
This handles two cases found in crash reports:

- "AssertionError: qWebKitVersion is not None" when QtWebKit itself is
  importable but qWebKitVersion is not. Fixes #5484.

- "ValueError: PyCapsule_GetPointer called with incorrect name" when importing
  QtWebKit - no idea what's going on here exactly.

Note that there might be other cases in the code where those imports are
attempted and only ImportError is handled (because ValueError really shouldn't
happen there...) - but we can't really track them down until we see more crash
reports with the same issue.
2020-06-16 17:26:13 +02:00
Florian Bruhin 590b73015b Rename urlmarks.py to test_urlmarks.py 2020-06-16 16:28:07 +02:00
Nicholas Lantz 267fb64fcb Renamed a couple of mouse settings.
Changed:
- input.mouse_backforward to input.mouse.back_forward_buttons
- input.rocker_gestures to input.mouse.rocker_gestures
2020-06-15 16:07:34 -06:00
Nicholas Lantz 3130944ee5 Merge branch 'master' of git://github.com/qutebrowser/qutebrowser 2020-06-15 15:40:51 -06:00
Florian Bruhin 7cbc447c55 Code scanning: Exclude C++ 2020-06-15 20:27:44 +02:00
Florian Bruhin e39b2335d6
Create codeql-analysis.yml 2020-06-15 20:24:13 +02:00
Florian Bruhin ed8de2786b Fix exception with invalid feature permission URLs 2020-06-15 19:03:28 +02:00
Florian Bruhin 8add93f49b Add note about colors.webpage.darkmode.policy.images on Qt 5.15.0
See #5505
2020-06-15 15:57:38 +02:00
Florian Bruhin 6d8553af3a Fix lint 2020-06-13 00:40:08 +02:00
Florian Bruhin 306eff2f94 Improve lost focusproxy handling
Disable the workaround if not on Qt 5.11, don't log if nothing was found, and
clean up the code a bit.
2020-06-13 00:19:01 +02:00
Florian Bruhin 0c6c566996 configdata: Remove comment about darkModeClassifierType
My analysis was correct and the setting now got removed from Chromium:
https://chromium-review.googlesource.com/c/chromium/src/+/2169489

Also see some other refactorings in the linked bug report:
https://bugs.chromium.org/p/chromium/issues/detail?id=1091095

See #5394
2020-06-12 23:43:45 +02:00
Florian Bruhin 2880e8215b Adjust version number in session warning 2020-06-12 13:53:46 +02:00
Florian Bruhin f07c704367 Improve some init logging 2020-06-12 12:40:12 +02:00
Florian Bruhin 24f7b1f369 requirements: Remove lxml from dev requirements
d805e2d71e removed lxml in check_coverage.py,
5e64aae70b removed ua_fetch.py

Thus, no lxml usages are remaining.
2020-06-12 12:31:05 +02:00
Florian Bruhin f9bcda0147 Fix unhandled SelectionUnsupportedError in :completion-item-yank 2020-06-11 22:20:17 +02:00
Florian Bruhin 049d51d1d7 Fix lint 2020-06-11 17:23:59 +02:00
Florian Bruhin 290f5ec527 Update changelog 2020-06-11 17:23:58 +02:00
Florian Bruhin 48fed500ef Add categories to qute://log 2020-06-11 17:23:58 +02:00
Florian Bruhin 58dc10ec66 Refactor log.LogFilter
This essentially does two things:

1) Use a set for LogFilter

This means we don't support filters like "eggs.bacon" anymore (but we *do*
support loggers like that) - however, those were already disallowed by the
--logfilter argument validation anyways!

In return, we get probably slightly better performance (checking set membership
rather than iterating all filters) and more straightforward code.

2) Move parsing from various locations around the code to the LogFilter class.
2020-06-11 16:57:54 +02:00
Florian Bruhin ac4fc1a1e3 command: Use consistent name for arg_info
(cherry picked from commit 279d28f982f3afe32c94fc938677bcad816b647e)
2020-06-11 15:49:25 +02:00
Florian Bruhin 025a70254f commands: Add some additional tests for *args handling
(cherry picked from commit 3983a6d3ee30f86b1afd809bc786322cbff8fd55)
2020-06-11 15:49:23 +02:00
Florian Bruhin ed26d43c16 Fix typo
(cherry picked from commit 7dceedb26bd5d0df97a97cd727e19fd9937bd850)
2020-06-11 15:49:18 +02:00
Florian Bruhin d9ecc35eef Fix lint 2020-06-11 14:26:19 +02:00
Florian Bruhin 34822bb530 Change logging format when the loglevel is changed via config 2020-06-11 12:44:31 +02:00
Florian Bruhin 3edaa17302 Fix lint 2020-06-11 12:37:57 +02:00
Florian Bruhin 33dd70dae6 Revert "tests: Separate init_from_config logs in utils.test_log"
Whoops... It uses fixtures from that test class!

This reverts commit a9d10aee84.
2020-06-11 12:34:50 +02:00
Florian Bruhin 679eaab28f Merge qute://plainlog into qute://log?plain 2020-06-11 12:12:56 +02:00
Florian Bruhin 2b629e0d3d qutescheme: Unify code between qute_log and qute_plainlog 2020-06-11 12:02:39 +02:00
Florian Bruhin fe9bde1b1d Switch some webview/misc logging messages to network logger 2020-06-11 11:56:22 +02:00
Florian Bruhin e21aad9094 Merge remote-tracking branch 'origin/pr/5474' 2020-06-11 11:47:22 +02:00
Florian Bruhin 49b0c73fdd Update changelog 2020-06-11 11:43:10 +02:00
Florian Bruhin a9d10aee84 tests: Separate init_from_config logs in utils.test_log 2020-06-11 11:39:05 +02:00
Florian Bruhin 23b5ee9777 Remove :debug-log-level
It's a hidden :debug-* command anyways, so no need to keep it around.
2020-06-11 11:37:51 +02:00
Ryan Roden-Corrent fab5f51373
Enable configuring loglevel at runtime.
Now `:set logging.level.{ram,console}` will work after qutebrowser has
started. This allows us to derecate debug-set-loglevel.

Logging is initialized too early for config.change_filter to work, so I
had to hack it.
2020-06-10 22:37:54 -04:00
Florian Bruhin 0af3a8a467 Update docs 2020-06-10 21:30:13 +02:00
Florian Bruhin bad288960a Merge remote-tracking branch 'origin/pr/5460' 2020-06-10 21:29:19 +02:00
Florian Bruhin 8d80910373 Update changelog 2020-06-10 20:41:36 +02:00
Florian Bruhin 80bdf46d89 Merge remote-tracking branch 'origin/pr/5516' 2020-06-10 20:40:19 +02:00
Florian Bruhin de98cab0f9 Merge remote-tracking branch 'origin/pr/5515' 2020-06-10 20:33:50 +02:00
Pierguido Lambri ec7dd49e16 Removed the useless debuginfo suffix
Signed-off-by: Pierguido Lambri <plambri@redhat.com>
2020-06-10 19:30:34 +01:00
Pierguido Lambri 6f545d3048 Fixed the debuginfo command, removed the sudo command and installed the right debug symbol packages for qtwebengine
Signed-off-by: Pierguido Lambri <plambri@redhat.com>
2020-06-10 19:23:28 +01:00
Pierguido Lambri 44e16ec2c6 Removed the sudo command
Signed-off-by: Pierguido Lambri <plambri@redhat.com>
2020-06-10 19:22:27 +01:00