Merge branch 'develop' into bump-deps

.github/CHANGELOG.md

@@ -8,6 +8,12 @@
 
   -
 
+## Release 1.2.1 November 17th 2022
+
+** Fixes **
+
+  - Fixes an issue with post thumbnails not being editable
+
 ## Release 1.2.0 November 15th 2022
 
 ** Enhancements **
@@ -36,7 +42,6 @@
   - Accessibility: aria role fixes for the carousel and footer widgets area
   - Translations: Makes aria-labels translatable
 
-
 ## Release 1.1.0 December 1st 2021
 
 ** Enhancements **

css/theme-bootstrap4.css

@@ -8757,7 +8757,7 @@ button.bg-dark:focus {
   }
 }
 
-.sr-only, a.skip-link {
+.sr-only {
   position: absolute;
   width: 1px;
   height: 1px;
@@ -8769,7 +8769,7 @@ button.bg-dark:focus {
   border: 0;
 }
 
-.sr-only-focusable:active, a.skip-link:active, .sr-only-focusable:focus, a.skip-link:focus {
+.sr-only-focusable:active, .sr-only-focusable:focus {
   position: static;
   width: auto;
   height: auto;
@@ -11086,6 +11086,26 @@ article img,
   height: auto;
 }
 
+a.skip-link {
+  position: absolute;
+  width: 1px;
+  height: 1px;
+  padding: 0;
+  margin: -1px;
+  overflow: hidden;
+  clip: rect(0, 0, 0, 0);
+  white-space: nowrap;
+  border: 0;
+}
+a.skip-link:active, a.skip-link:focus {
+  position: static;
+  width: auto;
+  height: auto;
+  overflow: visible;
+  clip: auto;
+  white-space: normal;
+}
+
 .navbar-dark .navbar-nav .dropdown-menu .nav-link {
   display: block;
   width: 100%;
@@ -14669,7 +14689,7 @@ figure.woocommerce-product-gallery__wrapper {
   content: "\f2e0";
 }
 
-.sr-only, a.skip-link {
+.sr-only {
   position: absolute;
   width: 1px;
   height: 1px;
@@ -14680,7 +14700,7 @@ figure.woocommerce-product-gallery__wrapper {
   border: 0;
 }
 
-.sr-only-focusable:active, a.skip-link:active, .sr-only-focusable:focus, a.skip-link:focus {
+.sr-only-focusable:active, .sr-only-focusable:focus {
   position: static;
   width: auto;
   height: auto;

css/theme.css

@@ -7746,8 +7746,7 @@ textarea.form-control-lg {
 }
 
 .visually-hidden,
-.visually-hidden-focusable:not(:focus):not(:focus-within),
-a.skip-link:not(:focus):not(:focus-within) {
+.visually-hidden-focusable:not(:focus):not(:focus-within) {
   position: absolute !important;
   width: 1px !important;
   height: 1px !important;
@@ -11792,6 +11791,18 @@ article img,
   height: auto;
 }
 
+a.skip-link:not(:focus):not(:focus-within) {
+  position: absolute !important;
+  width: 1px !important;
+  height: 1px !important;
+  padding: 0 !important;
+  margin: -1px !important;
+  overflow: hidden !important;
+  clip: rect(0, 0, 0, 0) !important;
+  white-space: nowrap !important;
+  border: 0 !important;
+}
+
 .navbar-dark .navbar-nav .dropdown-menu .nav-link {
   display: block;
   width: 100%;

header.php

@@ -29,7 +29,9 @@ $navbar_type       = get_theme_mod( 'understrap_navbar_type', 'collapse' );
 	<!-- ******************* The Navbar Area ******************* -->
 	<header id="wrapper-navbar">
 
-		<a class="skip-link" href="#content"><?php esc_html_e( 'Skip to content', 'understrap' ); ?></a>
+		<a class="skip-link <?php echo understrap_get_screen_reader_class( true ); ?>" href="#content">
+			<?php esc_html_e( 'Skip to content', 'understrap' ); ?>
+		</a>
 
 		<?php get_template_part( 'global-templates/navbar', $navbar_type . '-' . $bootstrap_version ); ?>
 

inc/setup.php

@@ -70,7 +70,7 @@ if ( ! function_exists( 'understrap_setup' ) ) {
 		/*
 		 * Adding Thumbnail basic support
 		 */
-		add_theme_support( 'post-thumbnails', array() );
+		add_theme_support( 'post-thumbnails' );
 
 		/*
 		 * Adding support for Widget edit icons in customizer

inc/template-tags.php

@@ -371,3 +371,20 @@ if ( ! function_exists( 'understrap_get_list_item_separator' ) ) {
 		return esc_html__( ', ', 'understrap' );
 	}
 }
+
+if ( ! function_exists( 'understrap_get_screen_reader_class' ) ) {
+	/**
+	 * Retrieves Bootstrap's screen reader text class.
+	 *
+	 * @param bool $focusable (Optional) Whether to make the screen reader text
+	 *                        visually focusable. Default: false.
+	 * @return string Bootstrap's screen reader text class.
+	 */
+	function understrap_get_screen_reader_class( $focusable = false ) {
+		$bootstrap_version = get_theme_mod( 'understrap_bootstrap_version', 'bootstrap4' );
+		if ( 'bootstrap4' === $bootstrap_version ) {
+			return $focusable ? 'sr-only sr-only-focusable' : 'sr-only';
+		}
+		return $focusable ? 'visually-hidden-focusable' : 'visually-hidden';
+	}
+}

js/theme-bootstrap4.js

@@ -1,5 +1,5 @@
 /*!
- * Understrap v1.2.0 (https://understrap.com)
+ * Understrap v1.2.1 (https://understrap.com)
  * Copyright 2013-2022 The UnderStrap Authors (https://github.com/understrap/understrap/graphs/contributors)
  * Licensed under GPL-3.0 (https://www.gnu.org/licenses/gpl-3.0.html)
  */

js/theme-bootstrap4.min.js

@@ -1,5 +1,5 @@
 /*!
- * Understrap v1.2.0 (https://understrap.com)
+ * Understrap v1.2.1 (https://understrap.com)
  * Copyright 2013-2022 The UnderStrap Authors (https://github.com/understrap/understrap/graphs/contributors)
  * Licensed under GPL-3.0 (https://www.gnu.org/licenses/gpl-3.0.html)
  */

js/theme.js

@@ -1,5 +1,5 @@
 /*!
- * Understrap v1.2.0 (https://understrap.com)
+ * Understrap v1.2.1 (https://understrap.com)
  * Copyright 2013-2022 The UnderStrap Authors (https://github.com/understrap/understrap/graphs/contributors)
  * Licensed under GPL-3.0 (https://www.gnu.org/licenses/gpl-3.0.html)
  */

js/theme.min.js

@@ -1,5 +1,5 @@
 /*!
- * Understrap v1.2.0 (https://understrap.com)
+ * Understrap v1.2.1 (https://understrap.com)
  * Copyright 2013-2022 The UnderStrap Authors (https://github.com/understrap/understrap/graphs/contributors)
  * Licensed under GPL-3.0 (https://www.gnu.org/licenses/gpl-3.0.html)
  */

languages/understrap.pot

@@ -2,7 +2,7 @@
 # This file is distributed under the GNU General Public License v3 or later.
 msgid ""
 msgstr ""
-"Project-Id-Version: Understrap 1.2.0\n"
+"Project-Id-Version: Understrap 1.2.1\n"
 "Report-Msgid-Bugs-To: https://wordpress.org/support/theme/understrap\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"

package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "understrap",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "understrap",
-      "version": "1.2.0",
+      "version": "1.2.1",
       "license": "GPL-3.0",
       "devDependencies": {
         "@babel/core": "^7.20.5",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "understrap",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "WordPress Theme framework",
   "main": "index.js",
   "scripts": {

phpcs.xml.dist

@@ -76,6 +76,7 @@
 				<element value="get_the_archive_title"/>
 				<element value="get_the_archive_description"/>
 				<element value="understrap_get_list_item_separator"/>
+				<element value="understrap_get_screen_reader_class"/>
 			</property>
 		</properties>
 	</rule>

src/sass/theme/_understrap.scss

@@ -150,10 +150,10 @@ article img,
 // Skip to content link
 a.skip-link {
 	@if variable-exists('bootstrap4') {
-		@extend .sr-only;
-		@extend .sr-only-focusable;
+		@include sr-only();
+		@include sr-only-focusable();
 	} @else {
-		@extend .visually-hidden-focusable;
+		@include visually-hidden-focusable();
 	}
 }
 

style.css

@@ -5,7 +5,7 @@ Author: Howard Development & Consulting
 Author URI: https://howarddc.com
 GitHub Theme URI: https://github.com/understrap/understrap
 Description: The renowned WordPress starter theme framework that combined Underscores and Bootstrap. Trusted by more than 100,000 developers for building handcrafted, custom WordPress sites.
-Version: 1.2.0
+Version: 1.2.1
 Requires at least: 5.0
 Tested up to: 6.1
 Requires PHP: 5.2