Added type checks in `icons-react` tests and ensured consistent dependency management in test packages. (#1439)

This commit is contained in:
Paweł Kuna 2025-12-22 19:50:20 +01:00 committed by GitHub
parent f76e44c631
commit 78e46e478d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
16 changed files with 10356 additions and 8678 deletions

View File

@ -70,7 +70,6 @@
"jsdom": "^24.0.0", "jsdom": "^24.0.0",
"lodash.template": "4.5.0", "lodash.template": "4.5.0",
"minimist": "1.2.8", "minimist": "1.2.8",
"sass": "^1.71.1",
"openai": "^4.73.1", "openai": "^4.73.1",
"parse-svg-path": "^0.1.2", "parse-svg-path": "^0.1.2",
"prettier": "^3.2.5", "prettier": "^3.2.5",
@ -82,15 +81,16 @@
"rollup-plugin-license": "^3.2.0", "rollup-plugin-license": "^3.2.0",
"rollup-plugin-peer-deps-external": "2.2.4", "rollup-plugin-peer-deps-external": "2.2.4",
"rollup-plugin-visualizer": "^5.12.0", "rollup-plugin-visualizer": "^5.12.0",
"sass": "^1.71.1",
"slash": "^5.1.0", "slash": "^5.1.0",
"svg-outline-stroke": "1.3.1", "svg-outline-stroke": "1.3.1",
"svgo": "^3.2.0", "svgo": "^3.2.0",
"svgpath": "^2.6.0", "svgpath": "^2.6.0",
"svgson": "^5.3.1", "svgson": "^5.3.1",
"turbo": "^1.12.5", "turbo": "^2.6.3",
"typescript": "^5.3.3", "typescript": "^5.3.3",
"vite": "^5.1.8", "vite": "^7.3.0",
"vitest": "^1.3.1" "vitest": "^4.0.16"
}, },
"release-it": { "release-it": {
"plugins": { "plugins": {
@ -113,7 +113,7 @@
"release": true "release": true
} }
}, },
"packageManager": "pnpm@8.15.9", "packageManager": "pnpm@10.26.0",
"pnpm": { "pnpm": {
"overrides": { "overrides": {
"sharp": "^0.33.5" "sharp": "^0.33.5"

View File

@ -42,7 +42,7 @@
"preact": "^10.5.13" "preact": "^10.5.13"
}, },
"devDependencies": { "devDependencies": {
"@preact/preset-vite": "^2.8.1", "@preact/preset-vite": "^2.10.2",
"@testing-library/preact": "^3.2.3", "@testing-library/preact": "^3.2.3",
"preact": "^10.19.6" "preact": "^10.19.6"
} }

View File

@ -32,6 +32,46 @@ export default [
], ],
plugins: [dts()], plugins: [dts()],
}, },
{
input: './src/icons/index.ts',
output: [
{
dir: 'dist/icons',
format: 'es',
preserveModules: true,
preserveModulesRoot: 'src',
},
],
plugins: [
dts({
compilerOptions: {
declaration: true,
emitDeclarationOnly: true,
},
}),
],
external: ['react', 'react-native-svg'],
},
{
input: './src/icons/index.ts',
output: [
{
dir: 'dist/cjs/icons',
format: 'es',
preserveModules: true,
preserveModulesRoot: 'src',
},
],
plugins: [
dts({
compilerOptions: {
declaration: true,
emitDeclarationOnly: true,
},
}),
],
external: ['react', 'react-native-svg'],
},
...getRollupConfig(pkg, outputFileName, bundles, { ...getRollupConfig(pkg, outputFileName, bundles, {
react: 'react', react: 'react',
'react-native-svg': 'react-native-svg', 'react-native-svg': 'react-native-svg',

View File

@ -12,4 +12,4 @@ export interface IconProps extends Partial<Omit<React.ComponentPropsWithoutRef<'
export type Icon = FunctionComponent<IconProps>; export type Icon = FunctionComponent<IconProps>;
export type TablerIcon = ForwardRefExoticComponent<Omit<IconProps, "ref"> & RefAttributes<Icon>>; export type TablerIcon = ForwardRefExoticComponent<IconProps & RefAttributes<SVGSVGElement>>;

View File

@ -1,6 +1,7 @@
import { describe, it, expect, afterEach, expectTypeOf } from 'vitest'; import { describe, it, expect, afterEach, expectTypeOf } from 'vitest';
import { render, cleanup } from '@testing-library/react' import { render, cleanup } from '@testing-library/react'
import { IconAccessible, IconAccessibleFilled, createReactComponent } from "./src/tabler-icons-react" import { IconAccessible, IconAccessibleFilled, createReactComponent } from "./src/tabler-icons-react"
import type { TablerIcon } from "./src/types"
describe("React Icon component", () => { describe("React Icon component", () => {
afterEach(() => { afterEach(() => {
@ -56,6 +57,11 @@ describe("React Icon component", () => {
expectTypeOf(IconAccessible).toEqualTypeOf(createReactComponent('outline', 'accessible', 'Accessible', [])); expectTypeOf(IconAccessible).toEqualTypeOf(createReactComponent('outline', 'accessible', 'Accessible', []));
}); });
it('should match TablerIcon type', () => {
expectTypeOf(IconAccessible).toMatchTypeOf<TablerIcon>();
expectTypeOf(IconAccessibleFilled).toMatchTypeOf<TablerIcon>();
});
it('should add title child element to svg when title prop is passed', () => { it('should add title child element to svg when title prop is passed', () => {
const { container } = render(<IconAccessible title="Accessible Icon"/>); const { container } = render(<IconAccessible title="Accessible Icon"/>);
const svg = container.getElementsByTagName("svg")[0]; const svg = container.getElementsByTagName("svg")[0];

View File

@ -68,7 +68,6 @@ describe("Svelte Icon component", () => {
it("should match snapshot", () => { it("should match snapshot", () => {
const { container } = render(IconAccessible); const { container } = render(IconAccessible);
expect(container.innerHTML).toMatchInlineSnapshot(` expect(container.innerHTML).toMatchInlineSnapshot(`
<div>
<svg xmlns="http://www.w3.org/2000/svg" <svg xmlns="http://www.w3.org/2000/svg"
width="24" width="24"
height="24" height="24"
@ -91,7 +90,6 @@ describe("Svelte Icon component", () => {
> >
</circle> </circle>
</svg> </svg>
</div>
`); `);
}); });
}); });

View File

@ -41,7 +41,7 @@
}, },
"devDependencies": { "devDependencies": {
"@testing-library/vue": "^8.0.2", "@testing-library/vue": "^8.0.2",
"@vitejs/plugin-vue": "^5.0.4", "@vitejs/plugin-vue": "^6.0.3",
"@vue/compiler-sfc": "^3.4.20", "@vue/compiler-sfc": "^3.4.20",
"@vue/test-utils": "2.4.4", "@vue/test-utils": "2.4.4",
"vue": "^3.4.20" "vue": "^3.4.20"

File diff suppressed because it is too large Load Diff

View File

@ -10,10 +10,10 @@
"clean": "rm -rf dist" "clean": "rm -rf dist"
}, },
"dependencies": { "dependencies": {
"@tabler/icons-preact": "3.36.0", "@tabler/icons-preact": "workspace:*",
"preact": "^10.19.6" "preact": "^10.19.6"
}, },
"devDependencies": { "devDependencies": {
"@preact/preset-vite": "^2.8.1" "@preact/preset-vite": "^2.10.2"
} }
} }

View File

@ -10,13 +10,13 @@
"clean": "rm -rf dist" "clean": "rm -rf dist"
}, },
"dependencies": { "dependencies": {
"@tabler/icons-react-native": "3.36.0", "@tabler/icons-react-native": "workspace:*",
"react": "^18.2.0", "react": "^18.2.0",
"react-dom": "^18.2.0" "react-dom": "^18.2.0"
}, },
"devDependencies": { "devDependencies": {
"@types/react": "^18.2.60", "@types/react": "^18.2.60",
"@types/react-dom": "^18.2.19", "@types/react-dom": "^18.2.19",
"@vitejs/plugin-react": "^4.2.1" "@vitejs/plugin-react": "^5.1.2"
} }
} }

View File

@ -1,7 +1,6 @@
import { useState } from 'react' import { useState } from 'react'
import './App.css' import './App.css'
import { IconAd, IconAdOff } from '@tabler/icons-react-native'; import { IconAd, IconAdOff, IconAdFilled } from '@tabler/icons-react-native';
import IconAdFilled from '@tabler/icons-react-native/IconAdFilled'
function App() { function App() {
const [active, setActive] = useState(false) const [active, setActive] = useState(false)

View File

@ -3,5 +3,32 @@ import react from '@vitejs/plugin-react'
// https://vitejs.dev/config/ // https://vitejs.dev/config/
export default defineConfig({ export default defineConfig({
plugins: [react()], plugins: [
react(),
{
name: 'exclude-react-native',
resolveId(id) {
if (id === 'react-native' || id.startsWith('react-native/')) {
return { id: 'react-native', external: true }
}
if (id === 'react-native-svg') {
return { id: 'react-native-svg', external: true }
}
},
},
],
optimizeDeps: {
exclude: ['react-native', 'react-native-svg'],
},
build: {
rollupOptions: {
external: (id) => {
return id === 'react-native' || id === 'react-native-svg' || id.startsWith('react-native/')
},
},
commonjsOptions: {
exclude: ['react-native', 'react-native-svg'],
transformMixedEsModules: true,
},
},
}) })

View File

@ -10,13 +10,13 @@
"clean": "rm -rf dist" "clean": "rm -rf dist"
}, },
"dependencies": { "dependencies": {
"@tabler/icons-react": "3.36.0", "@tabler/icons-react": "workspace:*",
"react": "^18.2.0", "react": "^18.2.0",
"react-dom": "^18.2.0" "react-dom": "^18.2.0"
}, },
"devDependencies": { "devDependencies": {
"@types/react": "^18.2.60", "@types/react": "^18.2.60",
"@types/react-dom": "^18.2.19", "@types/react-dom": "^18.2.19",
"@vitejs/plugin-react": "^4.2.1" "@vitejs/plugin-react": "^5.1.2"
} }
} }

View File

@ -11,7 +11,7 @@
"clean": "rm -rf dist" "clean": "rm -rf dist"
}, },
"dependencies": { "dependencies": {
"@tabler/icons-svelte": "3.36.0" "@tabler/icons-svelte": "workspace:*"
}, },
"devDependencies": { "devDependencies": {
"@sveltejs/vite-plugin-svelte": "^3.0.2", "@sveltejs/vite-plugin-svelte": "^3.0.2",

View File

@ -11,10 +11,10 @@
}, },
"dependencies": { "dependencies": {
"vue": "^3.4.20", "vue": "^3.4.20",
"@tabler/icons-vue": "3.36.0" "@tabler/icons-vue": "workspace:*"
}, },
"devDependencies": { "devDependencies": {
"@vitejs/plugin-vue": "^5.0.4", "@vitejs/plugin-vue": "^6.0.3",
"vue-tsc": "^1.8.27" "vue-tsc": "^3.1.8"
} }
} }

View File

@ -1,8 +1,8 @@
{ {
"$schema": "https://turbo.build/schema.json", "$schema": "https://turbo.build/schema.json",
"pipeline": { "tasks": {
"build": { "build": {
"outputs": ["dist/**", "src/icons/**"], "outputs": ["dist/**", "src/icons/**", "icons/**", "icons.json", "tabler-nodes-*.json", "categories/**", "docs/**"],
"dependsOn": ["^build"], "dependsOn": ["^build"],
"inputs": ["../../icons/**"] "inputs": ["../../icons/**"]
}, },