diff --git a/lib/core/resultsStorage/index.js b/lib/core/resultsStorage/index.js index abab025d6..0337891c8 100644 --- a/lib/core/resultsStorage/index.js +++ b/lib/core/resultsStorage/index.js @@ -15,13 +15,9 @@ function getDomainOrFileName(input) { return domainOrFile; } -module.exports = function( - input, - timestamp, - outputFolder, - resultBaseURL, - useHash -) { +module.exports = function(input, timestamp, options) { + const outputFolder = options.outputFolder; + const resultBaseURL = options.resultBaseURL; const resultsSubFolders = []; let storageBasePath; let storagePathPrefix; @@ -48,7 +44,7 @@ module.exports = function( } return { - storageManager: storageManager(storageBasePath, storagePathPrefix, useHash), - resultUrls: resultUrls(resultUrl, useHash) + storageManager: storageManager(storageBasePath, storagePathPrefix, options), + resultUrls: resultUrls(resultUrl, options.useHash) }; }; diff --git a/lib/core/resultsStorage/storageManager.js b/lib/core/resultsStorage/storageManager.js index ba1f398fe..3fcbadd55 100644 --- a/lib/core/resultsStorage/storageManager.js +++ b/lib/core/resultsStorage/storageManager.js @@ -14,7 +14,8 @@ function isValidDirectoryName(name) { return name !== undefined && name !== ''; } -module.exports = function storageManager(baseDir, storagePathPrefix, useHash) { +module.exports = function storageManager(baseDir, storagePathPrefix, options) { + const useHash = options.useHash; return { rootPathFromUrl(url) { return pathToFolder(url, useHash) diff --git a/lib/sitespeed.js b/lib/sitespeed.js index 3b7dd84eb..633bf9495 100644 --- a/lib/sitespeed.js +++ b/lib/sitespeed.js @@ -51,9 +51,7 @@ module.exports = { const { storageManager, resultUrls } = resultsStorage( url, timestamp, - options.outputFolder, - options.resultBaseURL, - options.useHash + options ); // Setup logging diff --git a/test/resultUrlTests.js b/test/resultUrlTests.js index 33bb99244..a6b08602c 100644 --- a/test/resultUrlTests.js +++ b/test/resultUrlTests.js @@ -8,7 +8,8 @@ const timestamp = dayjs(); const timestampString = timestamp.format('YYYY-MM-DD-HH-mm-ss'); function createResultUrls(url, outputFolder, resultBaseURL) { - return resultsStorage(url, timestamp, outputFolder, resultBaseURL).resultUrls; + return resultsStorage(url, timestamp, { outputFolder, resultBaseURL }) + .resultUrls; } describe('resultUrls', function() { diff --git a/test/storageManagerTests.js b/test/storageManagerTests.js index cdb44b0bb..3e2bc107f 100644 --- a/test/storageManagerTests.js +++ b/test/storageManagerTests.js @@ -9,7 +9,7 @@ const timestamp = dayjs(); const timestampString = timestamp.format('YYYY-MM-DD-HH-mm-ss'); function createManager(url, outputFolder) { - return resultsStorage(url, timestamp, outputFolder).storageManager; + return resultsStorage(url, timestamp, { outputFolder }).storageManager; } describe('storageManager', function() {