mirror
/
sitespeed.io
mirror of https://github.com/sitespeedio/sitespeed.io.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Returning N/A if nothing to display to fix issue with text overlay on tablet view of 'Requests and sizes per content type section of pages (#981)

This commit is contained in:
Jonathan Lee 2016-07-06 21:16:46 -05:00 committed by GitHub
parent f7edf8551c
commit de344d90b3
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -5,6 +5,7 @@
### Fixed
* The CSS size advice on summary page used the wrong metrics to check the color, meaning 0 bytes made it red :/
* Shorten long URLs displayed on HTML Asset report #977
* Empty size fixes for tablet view of HTML report
## 4.0.0-alpha5 - 2016-06-30
-------------------------

8
lib/plugins/html/helpers/size.js
View File

@ -10,14 +10,14 @@ module.exports = {
},
format(bytes) {
if (!bytes || bytes < 0)
return '';
return 'N/A';
if (bytes < KB) {
return Number(bytes) + ' b';
return Number(bytes) + ' B';
} else if (bytes < MB) {
return Number(bytes / KB).toFixed(1) + ' kb';
return Number(bytes / KB).toFixed(1) + ' KB';
} else {
return Number(bytes / MB).toFixed(1) + ' Mb';
return Number(bytes / MB).toFixed(1) + ' MB';
}
}
};