Filmstrips are only stored to disk if we collect visual metrics using trace. (#3188)

2020-11-06 18:09:05 +01:00 · 2020-11-06 18:09:05 +01:00 · d7eb1699c8
parent 777e4ef689
commit d7eb1699c8
1 changed files with 2 additions and 1 deletions
--- a/lib/plugins/browsertime/filmstrip.js
+++ b/lib/plugins/browsertime/filmstrip.js
@ -163,7 +163,8 @@ module.exports = {
  async getFilmstrip(browsertimeData, run, dir, options, fullPath) {
    let doWeHaveFilmstrip =
      (options.browsertime.chrome &&
-        options.browsertime.chrome.enableTraceScreenshots === true) ||
+        options.browsertime.chrome.enableTraceScreenshots === true &&
+        options.browsertime.chrome.visualMetricsUsingTrace === true) ||
      (options.browsertime.visualMetrics === true &&
        options.browsertime.videoParams.createFilmstrip === true);