Fix for spaces in your classpath on Windows running BT closes #358

This commit is contained in:
soulgalore 2014-01-26 12:42:46 +01:00
parent 917eab1861
commit cd29a6d356
2 changed files with 3 additions and 2 deletions

View File

@ -2,6 +2,7 @@ CHANGELOG sitespeed.io
version 2.6-wip
------------------------
* Bug fix: Fix for running BrowserTime in Windows and you have spaces in your path #358
version 2.5.3
------------------------

View File

@ -446,7 +446,7 @@ fi
# Log the versions
#*******************************************************
function log_versions {
browserTimeVersion=$($BROWSERTIME -V)
browserTimeVersion=$("$BROWSERTIME" -V)
echo "Using sitespeed.io version $SITESPEED_VERSION"
echo "Using PhantomJS version $(phantomjs --version)"
echo "Using Java version $jVersion"
@ -863,7 +863,7 @@ do
local pagefilename=$(get_filename $url $runs)
echo "Collecting Navigation Timing metrics (${BROWSERS_ARRAY[i]}): $url"
## Extra info: If you are using the Chrome driver on OS X, it always output "Starting the ChromeDriver ..." and this is a hack to remove that
($BROWSERTIME --compact --raw -b ${BROWSERS_ARRAY[i]} -n $NUMBER_OF_RUNS -o "$REPORT_DATA_METRICS_DIR/${BROWSERS_ARRAY[i]}/$pagefilename.xml" -ua "\"$USER_AGENT\"" -w $VIEWPORT "$url" 3>&1 1>&2 2>&3 | grep -v '^Starting' ) 3>&1 1>&2 2>&3 >> $REPORT_DATA_DIR/error.log
("$BROWSERTIME" --compact --raw -b ${BROWSERS_ARRAY[i]} -n $NUMBER_OF_RUNS -o "$REPORT_DATA_METRICS_DIR/${BROWSERS_ARRAY[i]}/$pagefilename.xml" -ua "\"$USER_AGENT\"" -w $VIEWPORT "$url" 3>&1 1>&2 2>&3 | grep -v '^Starting' ) 3>&1 1>&2 2>&3 >> $REPORT_DATA_DIR/error.log
## If BrowserTime fails, an empty file is created, so remove it
local btSize=$(du -k "$REPORT_DATA_METRICS_DIR/${BROWSERS_ARRAY[i]}/$pagefilename.xml" | cut -f1)