From a29c3f69e337cbef804609c1fa8ac98058e4bee0 Mon Sep 17 00:00:00 2001 From: Peter Hedenskog Date: Mon, 11 Dec 2017 23:58:20 +0100 Subject: [PATCH] Fix broken metrics list #1850 (#1853) --- lib/plugins/metrics/index.js | 37 ++++++++++++++++++------------------ 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/lib/plugins/metrics/index.js b/lib/plugins/metrics/index.js index 5a7f3416e..182f5ac68 100644 --- a/lib/plugins/metrics/index.js +++ b/lib/plugins/metrics/index.js @@ -18,6 +18,25 @@ module.exports = { processMessage(message) { const filterRegistry = this.filterRegistry; + if (message.type === 'sitespeedio.render') + if (this.options.list) { + // Ooops we should take care of promise + this.storageManager.writeData( + Object.keys(this.metrics).join('\n'), + 'metrics.txt' + ); + } + if (this.options.filterList) { + let output = ''; + let filtersByType = filterRegistry.getFilters(); + for (let type of Object.keys(filtersByType)) { + for (let filters of filtersByType[type]) { + output += type + '.' + filters + '\n'; + } + } + return this.storageManager.writeData(output, 'configuredMetrics.txt'); + } + if (this.options.list) { if ( !( @@ -71,24 +90,6 @@ module.exports = { } } } - if (message.type === 'sitespeedio.render') { - if (this.options.list) { - this.storageManager.writeData( - Object.keys(this.metrics).join('\n'), - 'metrics.txt' - ); - } - if (this.options.filterList) { - let output = ''; - let filtersByType = filterRegistry.getFilters(); - for (let type of Object.keys(filtersByType)) { - for (let filters of filtersByType[type]) { - output += type + '.' + filters + '\n'; - } - } - return this.storageManager.writeData(output, 'configuredMetrics.txt'); - } - } }, config: defaultConfig };