Use coach-core instead of webcoach directly (#2912)

* Use coach-core instead of webcoach directly

* use latest coach core

lib/plugins/browsertime/analyzer.js

@@ -6,7 +6,7 @@ const path = require('path');
 const browsertime = require('browsertime');
 const set = require('lodash.set');
 const get = require('lodash.get');
-const coach = require('webcoach');
+const coach = require('coach-core');
 
 const browserScripts = browsertime.browserScripts;
 

lib/plugins/browsertime/index.js

@@ -2,7 +2,7 @@
 
 const browsertime = require('browsertime');
 const aggregator = require('./aggregator');
-const api = require('webcoach');
+const api = require('coach-core');
 const log = require('intel').getLogger('plugin.browsertime');
 const merge = require('lodash.merge');
 const analyzer = require('./analyzer');
@@ -384,7 +384,7 @@ module.exports = {
               if (result.har) {
                 // make sure to get the right run in the HAR
                 const myHar = api.pickAPage(result.har, harIndex);
-                const harResult = await api.runHarAdvice(myHar);
+                const harResult = await api.analyseHar(myHar);
                 advice = api.merge(coachAdvice, harResult);
               }
               queue.postMessage(

lib/sitespeed.js

@@ -78,7 +78,7 @@ module.exports = {
       process.version,
       packageInfo.version,
       packageInfo.dependencies.browsertime,
-      packageInfo.dependencies.webcoach
+      packageInfo.dependencies['coach-core']
     );
     if (log.isEnabledFor(log.DEBUG)) {
       log.debug('Running with options: %:2j', options);

package.json

@@ -74,6 +74,7 @@
     "aws-sdk": "2.613.0",
     "axe-core": "3.5.1",
     "browsertime": "8.1.2",
+    "coach-core": "5.0.0",
     "cli-color": "1.4.0",
     "concurrent-queue": "7.0.2",
     "dayjs": "1.8.20",
@@ -108,7 +109,6 @@
     "text-table": "0.2.0",
     "third-party-web": "0.11.1",
     "uuid": "3.4.0",
-    "webcoach": "4.5.0",
     "webpagetest": "0.3.9",
     "yargs": "15.1.0"
   },