Add unit to slack summary (#3102)

lib/plugins/slack/summary.js

@@ -9,51 +9,60 @@ module.exports = function(dataCollector, errors, resultUrls, name, options) {
   const metrics = {
     firstPaint: {
       name: 'First paint',
-      metric: get(base.browsertime, 'summary.firstPaint.median')
+      metric: get(base.browsertime, 'summary.firstPaint.median'),
+      unit: 'ms'
     },
     domContentLoadedTime: {
       name: 'domContentLoadedTime',
       metric: get(
         base.browsertime,
         'summary.pageTimings.domContentLoadedTime.median'
-      )
+      ),
+      unit: 'ms'
     },
     speedIndex: {
       name: 'Speed Index',
-      metric: get(base.browsertime, 'summary.visualMetrics.SpeedIndex.median')
+      metric: get(base.browsertime, 'summary.visualMetrics.SpeedIndex.median'),
+      unit: 'ms'
     },
     firstVisualChange: {
       name: 'First Visual Change',
       metric: get(
         base.browsertime,
         'summary.visualMetrics.FirstVisualChange.median'
-      )
+      ),
+      unit: 'ms'
     },
     visualComplete85: {
       name: 'Visual Complete 85%',
       metric: get(
         base.browsertime,
         'summary.visualMetrics.VisualComplete85.median'
-      )
+      ),
+      unit: 'ms'
     },
     lastVisualChange: {
       name: 'Last Visual Change',
       metric: get(
         base.browsertime,
         'summary.visualMetrics.LastVisualChange.median'
-      )
+      ),
+      unit: 'ms'
     },
     fullyLoaded: {
       name: 'Fully Loaded',
-      metric: get(base.pagexray, 'summary.fullyLoaded.median')
+      metric: get(base.pagexray, 'summary.fullyLoaded.median'),
+      unit: 'ms'
     },
     coachScore: {
       name: 'Coach score',
-      metric: get(base.coach, 'summary.performance.score.median')
+      metric: get(base.coach, 'summary.performance.score.median'),
+      unit: ''
     },
     transferSize: {
       name: 'Page transfer weight',
-      metric: h.size.format(get(base.pagexray, 'summary.transferSize.median'))
+      metric: h.size.format(get(base.pagexray, 'summary.transferSize.median')),
+      unit: ''
     }
   };
   const iterations = get(options, 'browsertime.iterations', 0);
@@ -75,7 +84,13 @@ module.exports = function(dataCollector, errors, resultUrls, name, options) {
   summaryText += '*Site summary*' + message + '\n';
   for (const key of Object.keys(metrics)) {
     if (metrics[key].metric !== undefined) {
-      summaryText += metrics[key].name + ': ' + metrics[key].metric + '\n';
+      summaryText +=
+        metrics[key].name +
+        ': ' +
+        metrics[key].metric +
+        ' ' +
+        metrics[key].unit +
+        '\n';
     }
   }
 

test/slackTests.js

@@ -219,7 +219,7 @@ describe('slack', () => {
       expect(mock.called).to.be.true;
       const params = mock.callArgs[0];
       expect(params.text).to.equal(
-        '1 page analysed for Simple test (1 run, Chrome/desktop/unknown)\n*Site summary*\nPage transfer weight: N/A\n\n'
+        '1 page analysed for Simple test (1 run, Chrome/desktop/unknown)\n*Site summary*\nPage transfer weight: N/A \n\n'
       );
     });
 
@@ -238,7 +238,7 @@ describe('slack', () => {
       const params = mock.callArgs[0];
       expect(params.text).to.equal(
         '1 page analysed for Simple test (1 run, Chrome/desktop/unknown)\n*Site summary* ' +
-          '(<https://results.sitespeed.io/absolute/path/index.html |result>)\nPage transfer weight: N/A\n\n'
+          '(<https://results.sitespeed.io/absolute/path/index.html |result>)\nPage transfer weight: N/A \n\n'
       );
     });
 
@@ -259,7 +259,7 @@ describe('slack', () => {
       plugin.processMessage({ type: 's3.finished' });
       expect(mock.called).to.be.true;
       expect(mock.callArgs[0].text).to.equal(
-        '1 page analysed for S3 configured (1 run, Chrome/desktop/unknown)\n*Site summary*\nPage transfer weight: N/A\n\n'
+        '1 page analysed for S3 configured (1 run, Chrome/desktop/unknown)\n*Site summary*\nPage transfer weight: N/A \n\n'
       );
     });
 
@@ -284,7 +284,7 @@ describe('slack', () => {
       plugin.processMessage({ type: 'gcs.finished' });
       expect(mock.called).to.be.true;
       expect(mock.callArgs[0].text).to.equal(
-        '1 page analysed for GCS (1 run, Chrome/desktop/unknown)\n*Site summary*\nPage transfer weight: N/A\n\n'
+        '1 page analysed for GCS (1 run, Chrome/desktop/unknown)\n*Site summary*\nPage transfer weight: N/A \n\n'
       );
     });
   });