mirror
/
sitespeed.io
mirror of https://github.com/sitespeedio/sitespeed.io.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Getting connectivity was broken for influx and just luckily working f… (#2587) 

* Getting connectivity was broken for influx and just luckily working for Graphite.

* safer way to get the metric

* fix test case to follow correct JSON

* fix the fix
This commit is contained in:
Peter Hedenskog 2019-08-21 16:27:33 +02:00 committed by GitHub
parent 57060d39ae
commit 4c4d643db4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/support/tsdbUtil.js
View File

@ -13,7 +13,7 @@ module.exports = {
if (connectivity) {
return this.toSafeKey(connectivity);
} else {
return options.connectivity;
return get(options, 'browsertime.connectivity.profile', 'unknown');
}
},
getURLAndGroup(options, group, url, includeQueryParams, alias) {

18
test/graphiteTests.js
View File

@ -28,7 +28,11 @@ describe('graphite', function() {
let generator = new DataGenerator('ns', false, {
_: ['filename'],
browser: 'chrome',
connectivity: 'cable'
browsertime: {
connectivity: {
profile: 'cable'
}
}
});
const data = generator.dataFromMessage(message, dayjs());
@ -61,7 +65,11 @@ describe('graphite', function() {
let generator = new DataGenerator('ns', false, {
_: ['sub_domain_com'],
browser: 'chrome',
connectivity: 'cable'
browsertime: {
connectivity: {
profile: 'cable'
}
}
});
const data = generator.dataFromMessage(message, dayjs());
@ -94,7 +102,11 @@ describe('graphite', function() {
let generator = new DataGenerator('ns', false, {
_: ['sub_domain_com'],
browser: 'chrome',
connectivity: 'cable',
browsertime: {
connectivity: {
profile: 'cable'
}
},
graphite: { statsd: true }
});
const data = generator.dataFromMessage(message, dayjs());