mirror
/
sitespeed.io
mirror of https://github.com/sitespeedio/sitespeed.io.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect promise syntax. 

Always reject promises with an Error. This should fix the following, after sending an annotation to graphite/influxdb fails:

Warning: a promise was rejected with a non-error: [object Undefined]
This commit is contained in:
Tobias Lidskog 2017-09-14 08:50:06 +02:00
parent 34b3d67fb9
commit 2e4346bf8d
2 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/plugins/graphite/send-annotation.js
View File

@ -48,11 +48,11 @@ module.exports = {
const lib = options.graphite.httpPort === 443 ? https : http;
const req = lib.request(postOptions, res => {
if (res.statusCode !== 200) {
log.error(
'Got %s from Graphite when sending annotation',
res.statusCode
const e = new Error(
`Got ${res.statusCode} from Graphite when sending annotation`
);
reject();
log.warn(e.message);
reject(e);
} else {
res.setEncoding('utf8');
log.info('Sent annotation to Graphite');

9
lib/plugins/influxdb/send-annotation.js
View File

@ -56,12 +56,11 @@ module.exports = {
const lib = options.influxdb.protocol === 'https' ? https : http;
const req = lib.request(postOptions, res => {
if (res.statusCode !== 204) {
log.error(
'Got %s from InfluxDB when sending annotation %s',
res.statusCode,
res.statusMessage
const e = new Error(
`Got ${res.statusCode} from InfluxDB when sending annotation ${res.statusMessage}`
);
reject();
log.warn(e.message);
reject(e);
} else {
res.setEncoding('utf-8');
log.info('Sent annotation to InfluxDB');