mirror
/
sitespeed.io
mirror of https://github.com/sitespeedio/sitespeed.io.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Display filmstrip if we collect visual metrics and remove the video. (#2724)

This commit is contained in:
Peter Hedenskog 2019-10-23 23:41:13 +02:00 committed by GitHub
parent 4795484a85
commit 23cbd2b81c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/plugins/browsertime/filmstrip.js
View File

@ -127,6 +127,8 @@ module.exports = {
let doWeHaveFilmstrip =
options.browsertime.chrome.enableTraceScreenshots === true ||
(options.browsertime.video === true &&
options.browsertime.videoParams.createFilmstrip === true) ||
(options.browsertime.visualMetrics === true &&
options.browsertime.videoParams.createFilmstrip === true);
if (doWeHaveFilmstrip === false) {

2
lib/plugins/html/templates/url/iteration/index.pug
View File

@ -131,7 +131,7 @@ block content
section#video-panel
include ../video/index.pug
if options.browsertime.video && options.videoParams.createFilmstrip || options.browsertime.chrome.enableTraceScreenshots
if (options.browsertime.video || options.browsertime.visualMetrics) && options.videoParams.createFilmstrip || options.browsertime.chrome.enableTraceScreenshots
section#filmstrip-panel
include ../filmstrip/index.pug

2
lib/plugins/html/templates/url/iteration/tabs.pug
View File

@ -10,7 +10,7 @@
if options.browsertime.video
a(id='video', href='#video', onclick='return selectTab(this, true);')
| Video
if options.browsertime.video && options.videoParams.createFilmstrip || options.browsertime.chrome.enableTraceScreenshots
if (options.browsertime.video || options.browsertime.visualMetrics) && options.videoParams.createFilmstrip || options.browsertime.chrome.enableTraceScreenshots
a(id='filmstrip', href='#filmstrip', onclick='return selectTab(this, true);')
| Filmstrip
if d.coach && d.coach.run

2
lib/plugins/html/templates/url/summary/index.pug
View File

@ -136,7 +136,7 @@ block content
section#video-panel
include ../video/index.pug
if options.browsertime.video && options.videoParams.createFilmstrip || options.browsertime.chrome.enableTraceScreenshots
if (options.browsertime.video || options.browsertime.visualMetrics) && options.videoParams.createFilmstrip || options.browsertime.chrome.enableTraceScreenshots
section#filmstrip-panel
include ../filmstrip/index.pug

2
lib/plugins/html/templates/url/summary/tabs.pug
View File

@ -10,7 +10,7 @@
if options.browsertime.video
a(id='video', href='#video', onclick='return selectTab(this, true);')
| Video
if options.browsertime.video && options.videoParams.createFilmstrip || options.browsertime.chrome.enableTraceScreenshots
if (options.browsertime.video || options.browsertime.visualMetrics) && options.videoParams.createFilmstrip || options.browsertime.chrome.enableTraceScreenshots
a(id='filmstrip', href='#filmstrip', onclick='return selectTab(this, true);')
| Filmstrip
if d.coach && d.coach.pageSummary