From 227bc291cfd652cacc2d18559ef33ee3e384167a Mon Sep 17 00:00:00 2001 From: Peter Hedenskog Date: Mon, 23 Mar 2020 12:02:22 +0100 Subject: [PATCH] Send LCP load time to Graphite so you pick render/load and show max (#2940) --- lib/plugins/browsertime/default/metricsPageSummary.js | 2 ++ lib/plugins/html/templates/url/metrics/index.pug | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/plugins/browsertime/default/metricsPageSummary.js b/lib/plugins/browsertime/default/metricsPageSummary.js index c195f49c0..5806a7cc2 100644 --- a/lib/plugins/browsertime/default/metricsPageSummary.js +++ b/lib/plugins/browsertime/default/metricsPageSummary.js @@ -12,6 +12,8 @@ module.exports = [ 'statistics.timings.userTimings', 'statistics.timings.paintTiming', 'statistics.timings.largestContentfulPaint.renderTime', + 'statistics.timings.largestContentfulPaint.loadTime', + 'statistics.timings.elementTimings.*', 'statistics.timings.firstInput.delay', 'statistics.timings.firstInput.duration', diff --git a/lib/plugins/html/templates/url/metrics/index.pug b/lib/plugins/html/templates/url/metrics/index.pug index 9dd66a5c2..5a15ff8b7 100644 --- a/lib/plugins/html/templates/url/metrics/index.pug +++ b/lib/plugins/html/templates/url/metrics/index.pug @@ -129,7 +129,7 @@ if browsertime tr td a(href=baseHelpURL + 'largestContentfulPaint') Largest Contentful Paint - td.number #{h.time.ms(Math.max(timings.largestContentfulPaint.loadTime,timings.largestContentfulPaint.renderTime))} + td.number #{h.time.ms(Math.max(timings.largestContentfulPaint.loadTime,timings.largestContentfulPaint.renderTime, timings.largestContentfulPaint.loadTime,timings.largestContentfulPaint.loadTime))} if (timings.fullyLoaded) tr td