74c7ff2641
We create the DownloadManager with parent=qapp, which means they will stick
around forever after the test finished.
While we disconnect the QWebEngineProfile::downloadRequested() signal,
we keep the DownloadManager around, which also keeps around its download-update
timers.
Those will then result in tests/unit/utils/usertypes/test_timer.py::test_early_timeout_check
being flaky, as their _validity_check_handler slot keeps getting called in the
background. Due to the globally mocked time.monotonic(), this results in
nonsensical error messages such as:
Got logging message on logger misc with level WARNING:
Timer download-update (id ...) triggered too early:
interval 500 but only -1023.269s passed!
After this change, we now clean up those objects properly, thus fixing the
flakiness.
See #5390.
|
||
|---|---|---|
| .. | ||
| webengine | ||
| webkit | ||
| test_browsertab.py | ||
| test_caret.py | ||
| test_downloads.py | ||
| test_downloadview.py | ||
| test_hints.py | ||
| test_history.py | ||
| test_inspector.py | ||
| test_navigate.py | ||
| test_notification.py | ||
| test_pdfjs.py | ||
| test_qutescheme.py | ||
| test_shared.py | ||
| test_signalfilter.py | ||
| test_urlmarks.py | ||