246 lines
9.0 KiB
Python
246 lines
9.0 KiB
Python
# SPDX-FileCopyrightText: Daniel Schadt
|
|
# SPDX-FileCopyrightText: Florian Bruhin (The Compiler) <mail@qutebrowser.org>
|
|
#
|
|
# SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
"""Tests for the custom TabWidget/TabBar."""
|
|
|
|
import functools
|
|
|
|
import pytest
|
|
from unittest.mock import Mock
|
|
|
|
from qutebrowser.qt.gui import QIcon, QPixmap
|
|
from qutebrowser.mainwindow import tabwidget
|
|
from qutebrowser.utils import usertypes
|
|
|
|
|
|
class TestTabWidget:
|
|
|
|
"""Tests for TabWidget."""
|
|
|
|
@pytest.fixture
|
|
def widget(self, qtbot, monkeypatch, config_stub):
|
|
w = tabwidget.TabWidget(0)
|
|
qtbot.add_widget(w)
|
|
monkeypatch.setattr(tabwidget.objects, 'backend',
|
|
usertypes.Backend.QtWebKit)
|
|
w.show()
|
|
return w
|
|
|
|
def test_small_icon_doesnt_crash(self, widget, qtbot, fake_web_tab):
|
|
"""Test that setting a small icon doesn't produce a crash.
|
|
|
|
Regression test for #1015.
|
|
"""
|
|
# Size taken from issue report
|
|
pixmap = QPixmap(72, 1)
|
|
icon = QIcon(pixmap)
|
|
tab = fake_web_tab()
|
|
widget.addTab(tab, icon, 'foobar')
|
|
|
|
with qtbot.wait_exposed(widget):
|
|
widget.show()
|
|
|
|
# Sizing tests
|
|
|
|
def test_tab_size_same(self, widget, fake_web_tab):
|
|
"""Ensure by default, all tab sizes are the same."""
|
|
num_tabs = 10
|
|
for i in range(num_tabs):
|
|
widget.addTab(fake_web_tab(), 'foobar' + str(i))
|
|
|
|
first_size = widget.tabBar().tabSizeHint(0)
|
|
first_size_min = widget.tabBar().minimumTabSizeHint(0)
|
|
|
|
for i in range(num_tabs):
|
|
assert first_size == widget.tabBar().tabSizeHint(i)
|
|
assert first_size_min == widget.tabBar().minimumTabSizeHint(i)
|
|
|
|
@pytest.fixture
|
|
def paint_spy(self, monkeypatch):
|
|
spy = Mock()
|
|
monkeypatch.setattr(tabwidget, "QStylePainter", spy)
|
|
return spy
|
|
|
|
def test_tab_text_edlided_for_narrow_tabs(self, paint_spy, widget, fake_web_tab):
|
|
"""Make sure text gets elided for narrow tabs."""
|
|
widget.setMaximumWidth(100)
|
|
widget.addTab(fake_web_tab(), "one two three four")
|
|
|
|
fake_paint_event = Mock()
|
|
fake_paint_event.region.return_value.intersects.return_value = True
|
|
widget.tabBar().paintEvent(fake_paint_event)
|
|
|
|
style_opt = paint_spy.return_value.drawControl.call_args_list[0][0][1]
|
|
assert len(style_opt.text) < len(widget.tabBar().tabText(0))
|
|
assert style_opt.text.endswith("…")
|
|
assert len(style_opt.text) > len("…")
|
|
|
|
def test_tab_text_not_edlided_for_wide_tabs(self, paint_spy, widget, fake_web_tab):
|
|
"""Make sure text doesn't get elided for wide tabs."""
|
|
widget.setMaximumWidth(200)
|
|
widget.addTab(fake_web_tab(), "one two three four")
|
|
|
|
fake_paint_event = Mock()
|
|
fake_paint_event.region.return_value.intersects.return_value = True
|
|
widget.tabBar().paintEvent(fake_paint_event)
|
|
|
|
style_opt = paint_spy.return_value.drawControl.call_args_list[0][0][1]
|
|
assert style_opt.text.endswith(widget.tabBar().tabText(0))
|
|
|
|
@pytest.mark.parametrize("shrink_pinned", [True, False])
|
|
@pytest.mark.parametrize("vertical", [True, False])
|
|
def test_pinned_size(self, widget, fake_web_tab, config_stub,
|
|
shrink_pinned, vertical):
|
|
"""Ensure by default, pinned min sizes are forced to title.
|
|
|
|
If pinned.shrink is not true, then all tabs should be the same
|
|
|
|
If tabs are vertical, all tabs should be the same"""
|
|
num_tabs = 10
|
|
for i in range(num_tabs):
|
|
widget.addTab(fake_web_tab(), 'foobar' + str(i))
|
|
|
|
# Set pinned title format longer than unpinned
|
|
config_stub.val.tabs.title.format_pinned = "_" * 10
|
|
config_stub.val.tabs.title.format = "_" * 2
|
|
config_stub.val.tabs.pinned.shrink = shrink_pinned
|
|
if vertical:
|
|
# Use pixel width so we don't need to mock main-window
|
|
config_stub.val.tabs.width = 50
|
|
config_stub.val.tabs.position = "left"
|
|
|
|
pinned_num = [1, num_tabs - 1]
|
|
for num in pinned_num:
|
|
tab = widget.widget(num)
|
|
tab.set_pinned(True)
|
|
|
|
first_size = widget.tabBar().tabSizeHint(0)
|
|
first_size_min = widget.tabBar().minimumTabSizeHint(0)
|
|
|
|
for i in range(num_tabs):
|
|
if i in pinned_num and shrink_pinned and not vertical:
|
|
assert (first_size.width() >
|
|
widget.tabBar().tabSizeHint(i).width())
|
|
assert (first_size_min.width() <
|
|
widget.tabBar().minimumTabSizeHint(i).width())
|
|
else:
|
|
assert first_size == widget.tabBar().tabSizeHint(i)
|
|
assert first_size_min == widget.tabBar().minimumTabSizeHint(i)
|
|
|
|
@pytest.mark.parametrize("num_tabs", [4, 10, 50, 100])
|
|
def test_update_tab_titles_benchmark(self, benchmark, widget,
|
|
qtbot, fake_web_tab, num_tabs):
|
|
"""Benchmark for update_tab_titles."""
|
|
for i in range(num_tabs):
|
|
widget.addTab(fake_web_tab(), 'foobar' + str(i))
|
|
|
|
with qtbot.wait_exposed(widget):
|
|
widget.show()
|
|
|
|
benchmark(widget.update_tab_titles)
|
|
|
|
def test_tab_min_width(self, widget, fake_web_tab, config_stub, qtbot):
|
|
widget.addTab(fake_web_tab(), 'foobar')
|
|
widget.addTab(fake_web_tab(), 'foobar1')
|
|
min_size = widget.tabBar().tabRect(0).width() + 10
|
|
config_stub.val.tabs.min_width = min_size
|
|
assert widget.tabBar().tabRect(0).width() == min_size
|
|
|
|
def test_tab_max_width(self, widget, fake_web_tab, config_stub, qtbot):
|
|
widget.addTab(fake_web_tab(), 'foobar')
|
|
max_size = widget.tabBar().tabRect(0).width() - 10
|
|
config_stub.val.tabs.max_width = max_size
|
|
assert widget.tabBar().tabRect(0).width() == max_size
|
|
|
|
def test_tab_stays_hidden(self, widget, fake_web_tab, config_stub):
|
|
assert widget.tabBar().isVisible()
|
|
config_stub.val.tabs.show = "never"
|
|
assert not widget.tabBar().isVisible()
|
|
for i in range(12):
|
|
widget.addTab(fake_web_tab(), 'foobar' + str(i))
|
|
assert not widget.tabBar().isVisible()
|
|
|
|
@pytest.mark.parametrize("num_tabs", [4, 70])
|
|
@pytest.mark.parametrize("rev", [True, False])
|
|
def test_add_remove_tab_benchmark(self, benchmark, widget,
|
|
qtbot, fake_web_tab, num_tabs, rev):
|
|
"""Benchmark for addTab and removeTab."""
|
|
def _run_bench():
|
|
with qtbot.wait_exposed(widget):
|
|
widget.show()
|
|
for i in range(num_tabs):
|
|
idx = i if rev else 0
|
|
widget.insertTab(idx, fake_web_tab(), 'foobar' + str(i))
|
|
|
|
to_del = range(num_tabs)
|
|
if rev:
|
|
to_del = reversed(to_del)
|
|
for i in to_del:
|
|
widget.removeTab(i)
|
|
|
|
benchmark(_run_bench)
|
|
|
|
def test_tab_pinned_benchmark(self, benchmark, widget, fake_web_tab):
|
|
"""Benchmark for _tab_pinned."""
|
|
widget.addTab(fake_web_tab(), 'foobar')
|
|
tab_bar = widget.tabBar()
|
|
benchmark(functools.partial(tab_bar._tab_pinned, 0))
|
|
|
|
|
|
class TestTabBarShowOnClose:
|
|
|
|
@pytest.fixture
|
|
def widget(self, qtbot, monkeypatch, config_stub, fake_web_tab):
|
|
"""A tab widget with two tabs."""
|
|
w = tabwidget.TabWidget(0)
|
|
qtbot.add_widget(w)
|
|
monkeypatch.setattr(tabwidget.objects, 'backend',
|
|
usertypes.Backend.QtWebKit)
|
|
w.addTab(fake_web_tab(), 'tab1')
|
|
w.addTab(fake_web_tab(), 'tab2')
|
|
w.show()
|
|
return w
|
|
|
|
def test_show_on_close_true_and_switching(self, widget, config_stub, qtbot):
|
|
"""Test tabs.show_on_close=True and tabs.show='switching'."""
|
|
config_stub.val.tabs.show = 'switching'
|
|
config_stub.val.tabs.show_on_close = True
|
|
tab_bar = widget.tabBar()
|
|
qtbot.wait(1)
|
|
assert not tab_bar.isVisible()
|
|
|
|
widget.removeTab(0)
|
|
assert tab_bar.isVisible()
|
|
|
|
qtbot.wait(config_stub.val.tabs.show_switching_delay)
|
|
assert not tab_bar.isVisible()
|
|
|
|
def test_show_on_close_false(self, widget, config_stub, qtbot):
|
|
"""Test tabs.show_on_close=False."""
|
|
config_stub.val.tabs.show = 'switching'
|
|
config_stub.val.tabs.show_on_close = False
|
|
tab_bar = widget.tabBar()
|
|
qtbot.wait(1)
|
|
assert not tab_bar.isVisible()
|
|
|
|
widget.removeTab(0)
|
|
assert not tab_bar.isVisible()
|
|
|
|
@pytest.mark.parametrize('show_val,is_visible', [
|
|
('always', True),
|
|
('never', False),
|
|
])
|
|
def test_show_on_close_true_not_switching(self, widget, config_stub, qtbot,
|
|
show_val, is_visible):
|
|
"""Test tabs.show_on_close=True and tabs.show!='switching'."""
|
|
config_stub.val.tabs.show = show_val
|
|
config_stub.val.tabs.show_on_close = True
|
|
tab_bar = widget.tabBar()
|
|
qtbot.wait(1)
|
|
assert tab_bar.isVisible() is is_visible
|
|
|
|
widget.removeTab(0)
|
|
assert tab_bar.isVisible() is is_visible
|