Commit Graph

86 Commits

Author SHA1 Message Date
toofar c5fa5a0dc9 lint: Add misc check for QTimer initialization
Since we added some sanity checking in usertypes.Timer() around
QTBUG-124496 it would be convenient if there was a reminder for future
timer users to use our Timer object instead. Here's one!

It's looking for QTimer initialisations, we are still allowing
QTimer.singleShot(), although that probably can hit the same issue.

It uses an end-of-line anchor in the regex so you can put a comment (any
comment) on the end of the line to ignore the check.
2024-05-25 09:34:01 +12:00
Florian Bruhin 470ec752e1 Add Riverbank Computing as extra index for PyQt requirements
Easier fix instead of 6c4be8ef03.
Seems to get picked up just fine, and shouldn't hurt when it's not needed, as we
don't use --pre. Thus, no development releases should be installed.
2024-05-24 17:08:56 +02:00
Florian Bruhin 09fd975af7 reuse: Add linting for old license comments 2023-07-23 13:53:31 +02:00
Florian Bruhin 0718b25796 reuse: Initial copyright text update for myself
git ls-files | \
    xargs sed -Ei 's/Copyright [0-9]{4}(-[0-9]{4}) Florian Bruhin \(The Compiler\) <mail@qutebrowser\.org>/SPDX-FileCopyrightText: Florian Bruhin (The Compiler) <mail@qutebrowser.org>/'
2023-07-23 12:49:05 +02:00
Florian Bruhin b2aaba6043 reuse: Adjust most license headers
git ls-files | xargs grep -l "is free software"  | xargs reuse annotate --license="GPL-3.0-or-later" --skip-unrecognised
2023-07-23 12:11:07 +02:00
Florian Bruhin d48d85324e qt6: Reduce duplicate misc_checks.py code 2023-06-30 19:29:28 +02:00
Florian Bruhin 0e9f5e7e4f scripts: Upgrade to Qt 6
Using qutebrowser.qt where we import from qutebrowser already anyways
2023-06-30 19:29:28 +02:00
Florian Bruhin 8e024ee654
Merge pull request #7761 from pylbrecht/remove-vim-modelines
Remove vim modelines in favor of .editorconfig
2023-06-30 15:51:19 +02:00
Florian Bruhin 4cf2eea580 qt6 mypy: Fix lint 2023-06-30 11:59:45 +02:00
Philipp Albrecht 6f727664a9 Add misc check to prevent vim modelines
We deprecated vim modelines. The introduced misc check will keep old pull requests from
re-introducing vim modelines.
2023-06-30 11:03:19 +02:00
Philipp Albrecht d9e8b638bf Remove vim modelines
We're deprecating vim modelines in favor of `.editorconfig`.

Removing vim modelines could be done using two one-liners. Most of the vim modelines
were followed by an empty line, so this one-liner took care of these ones:

```sh
rg '^# vim: .+\n\n' -l | xargs sed -i '/^# vim: /,+1d'
```

Then some of the vim modelines were followed by a pylint configuration line, so running
this one-liner afterwards took care of that:

```sh
rg '^# vim:' -l | xargs sed -i '/^# vim: /d'
```
2023-06-30 11:03:06 +02:00
Florian Bruhin a6d4227578 qt6 mypy: Fix lint 2023-06-30 00:29:16 +02:00
Florian Bruhin b4d32e04f4 Merge branch 'master' into qt6-v2 2022-12-13 09:05:32 +01:00
toofar 2d66466194 Merge branch 'master' into qt6-v2
Just a few conflicts around CI and dependencies.
2022-11-20 15:48:00 +13:00
Kian-Meng Ang d77b0fb8a3 Fix typos
Found via `codespell -S *.js -L
technik,gir,nam,ans,wih,wil,ro,nowe,te,datas,qutie,ned,fo,clude,alph,crashers,nd,wasn,cros,ue,possition`

Co-authored-by: Marcel Schilling <marcel.schilling@uni-luebeck.de>
2022-11-19 13:03:39 +08:00
Florian Bruhin bc225557a5 Adjust warnings and changelog URLs for new pytest 2022-10-31 08:19:25 +01:00
Florian Bruhin fa62360357 Remove unneeded str
Only needed in Python 3.5 times
2022-09-30 20:23:38 +02:00
Florian Bruhin a6becca540 scripts: Add check for direct PyQt imports 2022-08-23 18:31:42 +02:00
Florian Bruhin 5aa9cb7401 Fix misc checks 2022-08-23 18:31:41 +02:00
Florian Bruhin ab7a2ee558 Switch to Python 3.7 subprocess API
Follow-up for #6905
2022-04-04 16:58:31 +02:00
Florian Bruhin f7bf9d0c33 Mark qute-pass as executable and add checker
Regressed in #7068
2022-04-02 12:45:40 +02:00
Florian Bruhin db720b1454 Let mypy check for blanket ignores 2022-03-14 10:04:36 +01:00
Florian Bruhin 10267f70e3 scripts: Move changelog URLs to JSON 2022-01-10 10:01:29 +01:00
Florian Bruhin 7cee566026 Fix spell check regex 2021-03-17 18:50:38 +01:00
Florian Bruhin ed20af9828 Improve joinpath regex
joinpath is still useful with a list of args
2021-03-15 14:04:19 +01:00
Florian Bruhin 6d26ba60ff scripts: Add some additional checks for pathlib 2021-03-10 22:33:59 +01:00
Florian Bruhin 2c8dec9ece misc_check: Print match instead of pattern 2021-03-01 21:20:56 +01:00
Florian Bruhin 6f6232e53c Re-add trailing comma 2021-03-01 21:19:11 +01:00
Lembrun 1ee39297cb Changes to generic regexp added 2021-03-01 20:28:42 +01:00
Lembrun f767188abf Generic regexp to detect Camel case qtbot methods 2021-02-27 18:07:28 +01:00
Lembrun a013b81896 Merged into spelling 2021-02-26 22:47:46 +01:00
Lembrun e8b05af233 Qtbot methods changed to snake case,snake case check added 2021-02-26 22:07:08 +01:00
Florian Bruhin 8f9d07674c Use and enforce python3 shebangs in userscripts
See #6080
2021-01-28 16:11:13 +01:00
Florian Bruhin 7576dc2719 Get rid of IOError
It's an alias to OSError since Python 3.3:
https://docs.python.org/3/library/exceptions.html
https://www.python.org/dev/peps/pep-3151/
2021-01-26 17:49:39 +01:00
Florian Bruhin 1a4fff1a42 doc: Switch URLs to https 2021-01-26 15:19:01 +01:00
Florian Bruhin 222f1f19a1 Bump copyright years
Closes #6015
2021-01-20 20:06:19 +01:00
Florian Bruhin 47eb949b31 ci: Add check for attrs 2021-01-14 13:51:18 +01:00
Florian Bruhin 99017c50ac Trivial PyQt 6 changes
See #5395
2021-01-08 10:47:02 +01:00
Florian Bruhin 1723278aae Add additional spelling checks 2020-12-30 13:51:07 +01:00
Florian Bruhin 6e40605ae1 scripts: Improve output for misc_checks
- Don't output type annotation message for "# type: ignore"
- Output entire message colored
- Strip colors in problemmatcher regex
2020-12-03 17:07:08 +01:00
Florian Bruhin e07611fc31 Enforce /usr/bin/env shebangs in userscripts
See https://github.com/qutebrowser/qutebrowser/discussions/5927#discussioncomment-145322
2020-12-03 11:09:20 +01:00
Florian Bruhin ad2067bf54 Update/enforce changelog URLs 2020-11-09 12:39:23 +01:00
Florian Bruhin d6e1d78477 tests: Use three-argument form of monkeypatch 2020-11-03 23:06:11 +01:00
Florian Bruhin 3776809c8e Fix lint 2020-11-02 17:59:50 +01:00
Florian Bruhin d5b08d1516 scripts: Add typing. check to misc_checks.py 2020-11-02 17:14:24 +01:00
Florian Bruhin 33c80e386c scripts: Disallow type comments in misc_checks 2020-11-02 17:09:19 +01:00
Florian Bruhin 0487383836 scripts: Disallow blanket noqa/type ignores 2020-11-02 17:02:06 +01:00
Florian Bruhin 6d04af727d scripts: Improve spell checks in misc_checks.py
- Precompile patterns which leads to a nice speedup (8s -> 2.75s on my machine)
- Add an explanation
- Output messages in a way we can use GitHub Actions problem matchers
- Add those problem matchers
2020-11-02 16:50:33 +01:00
Florian Bruhin 0a5c2114c1 scripts: Add 'all' to misc_checks 2020-11-02 16:29:02 +01:00
Florian Bruhin abed001aa9 misc_checks: Handle remaining binary files gracefully 2020-09-10 16:40:23 +02:00