From f9bcda014727f97b3b253a922a155d6499202166 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 11 Jun 2020 22:20:17 +0200 Subject: [PATCH] Fix unhandled SelectionUnsupportedError in :completion-item-yank --- doc/changelog.asciidoc | 2 ++ qutebrowser/completion/completionwidget.py | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/doc/changelog.asciidoc b/doc/changelog.asciidoc index eaf4f5146..03d97f87b 100644 --- a/doc/changelog.asciidoc +++ b/doc/changelog.asciidoc @@ -67,6 +67,8 @@ Fixed - Crash when `tabs.focus_stack_size` is set to -1. - Crash when a `pdf.js` file for PDF.js exists, but `viewer.html` does not. +- Crash when `:completion-item-yank --sel` is used on a platform without + primary selection support (e.g. Windows/macOS). - `:config-write-py` now works with paths starting with `~/...` again. - New site-specific quirk for a missing `globalThis` in Qt <= 5.12 on Reddit and Spotify diff --git a/qutebrowser/completion/completionwidget.py b/qutebrowser/completion/completionwidget.py index b9be0bd9d..26fbcdf4f 100644 --- a/qutebrowser/completion/completionwidget.py +++ b/qutebrowser/completion/completionwidget.py @@ -424,4 +424,8 @@ class CompletionView(QTreeView): if not index.isValid(): raise cmdutils.CommandError("No item selected!") text = self.model().data(index) + + if not utils.supports_selection(): + sel = False + utils.set_clipboard(text, selection=sel)