From f891dd31372b63c42fa0e0c74dc621f1c8d9e80e Mon Sep 17 00:00:00 2001 From: toofar Date: Mon, 28 Oct 2024 11:54:43 +1300 Subject: [PATCH] Wait for quteproc shutdown in across-restarts prompt test This is failing with: ERROR tests/end2end/test_invocations.py::test_permission_prompt_across_restart - PermissionError: [WinError 5] Access is denied: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpytep6gj0\\cache\\webengine\\Cache\\Cache_Data\\data_0' In pytest teardown, while trying to clean up a temp dir, probably the basedir. The test above waits for shutdown at the end of the test, maybe that's what's needed here. Otherwise maybe just `@pytest.mark.skipif(utils.is_windows)` :shrug: --- tests/end2end/test_invocations.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/end2end/test_invocations.py b/tests/end2end/test_invocations.py index a5a03ecf6..75df387fb 100644 --- a/tests/end2end/test_invocations.py +++ b/tests/end2end/test_invocations.py @@ -662,6 +662,9 @@ def test_permission_prompt_across_restart(quteproc_new, request, short_tmpdir): # We should be re-prompted in the new instance notification_prompt('no') + quteproc_new.send_cmd(':quit') + quteproc_new.wait_for_quit() + # The 'colors' dictionaries in the parametrize decorator below have (QtWebEngine # version, CPU architecture) as keys. Either of those (or both) can be None to