From f3d280ba53e4977eb97cec53690603374dd625fb Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 5 Dec 2024 15:04:56 +0100 Subject: [PATCH] Expand comment --- qutebrowser/browser/shared.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/qutebrowser/browser/shared.py b/qutebrowser/browser/shared.py index 8e726ce18..bd21f6863 100644 --- a/qutebrowser/browser/shared.py +++ b/qutebrowser/browser/shared.py @@ -48,6 +48,13 @@ def custom_headers( encoded_value = b"" if value is None else value.encode('ascii') headers[encoded_header] = encoded_value + # On QtWebEngine, we have fallback_accept_language set to False here for XHR + # requests, so that we don't end up overriding headers that are set via the XHR API. + # + # The global Accept-Language header is set via + # QWebEngineProfile::setHttpAcceptLanguage already anyways, so we only need + # to take care of URL pattern overrides here. + # # note: Once we drop QtWebKit, we could hardcode fallback_accept_language to False. accept_language = config.instance.get('content.headers.accept_language', url=url, fallback=fallback_accept_language)