From f2547f8a09d2b858f2e63bbd112576c4774ebea7 Mon Sep 17 00:00:00 2001
From: Florian Bruhin <me@the-compiler.org>
Date: Sun, 30 Nov 2025 18:45:48 +0100
Subject: [PATCH] scripts: Make smoke test fail output less confusing

---
 scripts/dev/build_release.py | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/scripts/dev/build_release.py b/scripts/dev/build_release.py
index ab8844e6a..8dd3aa5c3 100755
--- a/scripts/dev/build_release.py
+++ b/scripts/dev/build_release.py
@@ -208,8 +208,12 @@ def smoke_test(executable: pathlib.Path, debug_build: bool) -> None:
         proc = _smoke_test_run(executable)
     except subprocess.CalledProcessError as e:
         print(f"Smoke test failed: {e}, running with --debug")
-        smoke_test_debug(executable, original_stdout=e.stdout.decode('utf-8'),
-                         original_stderr=e.stderr.decode('utf-8'))
+        smoke_test_debug(
+            executable,
+            original_stdout=e.stdout.decode("utf-8"),
+            original_stderr=e.stderr.decode("utf-8"),
+            issue_description=str(e),
+        )
         return
 
     if debug_build:
@@ -221,11 +225,20 @@ def smoke_test(executable: pathlib.Path, debug_build: bool) -> None:
 
     if stdout or stderr:
         print("Unexpected output, running with --debug")
-        smoke_test_debug(executable, original_stdout=stdout, original_stderr=stderr)
+        smoke_test_debug(
+            executable,
+            original_stdout=stdout,
+            original_stderr=stderr,
+            issue_description="Unexpected output",
+        )
 
 
 def smoke_test_debug(
-    executable: pathlib.Path, *, original_stdout: str, original_stderr: str
+    executable: pathlib.Path,
+    *,
+    original_stdout: str,
+    original_stderr: str,
+    issue_description: str,
 ) -> None:
     """Run smoke test in debug mode to get more output."""
     proc = _smoke_test_run(executable, '--debug')
@@ -233,7 +246,7 @@ def smoke_test_debug(
     debug_stderr = proc.stderr.decode('utf-8')
 
     lines = [
-        "Unexpected output!",
+        issue_description,
         "",
     ]
     if original_stdout: