Remove deprecated :inspector

This commit is contained in:
Florian Bruhin 2020-11-13 10:32:28 +01:00
parent e2ed55ec2a
commit d5ac552f20
4 changed files with 8 additions and 13 deletions

View File

@ -53,6 +53,8 @@ Removed
- The `--old` flag for `:config-diff` has been removed. It used to show
customized options for the old pre-v1.0 config files (in order to aid
migration to v1.0).
- The `:inspector` command which was deprecated in v1.13.0 (in favor of
`:devtools`) is now removed.
Changed
~~~~~~~

View File

@ -343,10 +343,3 @@ def devtools_focus(tab: apitypes.Tab) -> None:
tab.data.splitter.cycle_focus()
except apitypes.InspectorError as e:
raise cmdutils.CommandError(e)
@cmdutils.register(deprecated='Use :devtools instead')
@cmdutils.argument('tab', value=cmdutils.Value.cur_tab)
def inspector(tab: apitypes.Tab) -> None:
"""Toggle the web inspector."""
devtools(tab)

View File

@ -41,10 +41,10 @@ Feature: Keyboard input
@no_xvfb @posix @qtwebengine_skip
Scenario: :fake-key sending key to the website with other window focused
When I open data/keyinput/log.html
And I run :inspector
And I run :devtools
And I wait for "Focus object changed: <PyQt5.QtWebKitWidgets.QWebView object at *>" in the log
And I run :fake-key x
And I run :inspector
And I run :devtools
And I wait for "Focus object changed: <qutebrowser.browser.webkit.webview.WebView *>" in the log
Then the error "No focused webview!" should be shown

View File

@ -173,18 +173,18 @@ Feature: Various utility commands.
@no_xvfb @posix @qtwebengine_skip
Scenario: Inspector smoke test
When I run :inspector
When I run :devtools
And I wait for "Focus object changed: <PyQt5.QtWebKitWidgets.QWebView object at *>" in the log
And I run :inspector
And I run :devtools
And I wait for "Focus object changed: *" in the log
Then no crash should happen
# Different code path as an inspector got created now
@no_xvfb @posix @qtwebengine_skip
Scenario: Inspector smoke test 2
When I run :inspector
When I run :devtools
And I wait for "Focus object changed: <PyQt5.QtWebKitWidgets.QWebView object at *>" in the log
And I run :inspector
And I run :devtools
And I wait for "Focus object changed: *" in the log
Then no crash should happen