mirror
/
qutebrowser
mirror of https://github.com/qutebrowser/qutebrowser.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tests: Ignore test_restart hang on Windows

This commit is contained in:
Florian Bruhin 2025-06-05 15:09:57 +02:00
parent 2e343403de
commit c1e7b6e8f3
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tests/end2end/test_invocations.py
View File

@ -1039,11 +1039,13 @@ def test_restart(request, quteproc_new):
pid = int(line.message.removeprefix(prefix))
os.kill(pid, signal.SIGTERM)
try:
# If the new process hangs, this will hang too.
# Still better than just ignoring it, so we can fix it if something is broken.
os.waitpid(pid, 0) # pid, options... positional-only :(
except (ChildProcessError, PermissionError):
# Already gone. Even if not documented, Windows seems to raise PermissionError
# here...
pass
# This often hangs on Windows for unknown reasons
if not utils.is_windows:
try:
# If the new process hangs, this will hang too.
# Still better than just ignoring it, so we can fix it if something is broken.
os.waitpid(pid, 0) # pid, options... positional-only :(
except (ChildProcessError, PermissionError):
# Already gone. Even if not documented, Windows seems to raise PermissionError
# here...
pass