Make herbe process error non-fatal

2023-06-05 13:02:42 +02:00 · 2023-06-05 13:02:42 +02:00 · a71c25c2a0
parent a7ad16daef
commit a71c25c2a0
2 changed files with 2 additions and 1 deletions
--- a/doc/changelog.asciidoc
+++ b/doc/changelog.asciidoc
@ -168,6 +168,7 @@ Fixed
 - Crash with some notification servers when the server is quitting.
 - Crash when using QtWebKit with PAC and the file has an invalid encoding.
 - Crash with the "tiramisu" notification server.
+- Crash when the "herbe" notification presenter doesn't start correctly.

 [[v2.5.4]]
 v2.5.4 (2023-03-13)
--- a/qutebrowser/browser/webengine/notification.py
+++ b/qutebrowser/browser/webengine/notification.py
@ -637,7 +637,7 @@ class HerbeNotificationAdapter(AbstractNotificationAdapter):
        if error == QProcess.ProcessError.Crashed:
            return
        name = debug.qenum_key(QProcess.ProcessError, error)
-        raise Error(f'herbe process error: {name}')
+        self.error.emit(f'herbe process error: {name}')

    @pyqtSlot(int)
    def on_web_closed(self, notification_id: int) -> None: