mypy: defer to machinery for conditional: QtSql bound values

Also turn the qt5 value into a list instead of a dict_values, for the
sake of mypy
This commit is contained in:
toofar 2022-09-11 11:06:47 +12:00
parent 42d3cca794
commit 9e1dfacef7
1 changed files with 4 additions and 4 deletions

View File

@ -29,7 +29,7 @@ from typing import Any, Dict, Iterator, List, Mapping, MutableSequence, Optional
from qutebrowser.qt.core import QObject, pyqtSignal
from qutebrowser.qt.sql import QSqlDatabase, QSqlError, QSqlQuery
from qutebrowser.qt import sip
from qutebrowser.qt import sip, machinery
from qutebrowser.utils import debug, log
@ -352,10 +352,10 @@ class Query:
def _validate_bound_values(self):
"""Make sure all placeholders are bound."""
qt_bound_values = self.query.boundValues()
try:
if machinery.IS_QT5:
# Qt 5: Returns a dict
values = qt_bound_values.values()
except AttributeError:
values = list(qt_bound_values.values())
else:
# Qt 6: Returns a list
values = qt_bound_values