Update comments/changelog
This commit is contained in:
parent
b73f93fb1f
commit
76d9c7f6ea
|
|
@ -22,14 +22,16 @@ Major changes
|
|||
~~~~~~~~~~~~~
|
||||
|
||||
- Quick checklist for packagers:
|
||||
* Ensure you're providing at least Python 3.6.1
|
||||
* Ensure you're providing at least Qt 5.12 and PyQt 5.12
|
||||
* Ensure you're providing at least Python 3.6.1.
|
||||
* Ensure you're providing at least Qt 5.12 and PyQt 5.12.
|
||||
* Add a new optional dependency on the Python `adblock` library (if packaged -
|
||||
if not, consider packaging it, albeit optional it's very useful for users)
|
||||
* Remove the `cssutils` optional dependency (if present)
|
||||
* Remove the `attrs` (`attr`) dependency
|
||||
* Remove the `pypeg2` dependency
|
||||
* Move the `pygments` dependency from required to optional
|
||||
if not, consider packaging it, albeit optional it's very useful for users).
|
||||
* Remove the `cssutils` optional dependency (if present).
|
||||
* Remove the `attrs` (`attr`) dependency.
|
||||
* Remove the `pypeg2` dependency (and perhaps consider dropping the package
|
||||
if not used elsewhere - it's https://fdik.org/pyPEG2/[inactive upstream]
|
||||
and the repository was removed by Bitbucket).
|
||||
* Move the `pygments` dependency from required to optional.
|
||||
* TODO: Move the `setuptools` dependency from runtime (for `pkg_resources`) to
|
||||
build-time.
|
||||
* For Python 3.6, 3.7 or 3.8, add a dependency on the `importlib_resources`
|
||||
|
|
|
|||
|
|
@ -230,7 +230,7 @@ def _qtwebengine_settings_args() -> Iterator[str]:
|
|||
not qtutils.version_check('5.15.2', compiled=False)):
|
||||
# In Qt 5.14 to 5.15.1, `--force-dark-mode` is used to set the
|
||||
# preferred colorscheme. In Qt 5.15.2, this is handled by a
|
||||
# blink-setting instead.
|
||||
# blink-setting in browser/webengine/darkmode.py instead.
|
||||
settings['colors.webpage.prefers_color_scheme_dark'] = {
|
||||
True: '--force-dark-mode',
|
||||
False: None,
|
||||
|
|
|
|||
Loading…
Reference in New Issue