mirror
/
qutebrowser
mirror of https://github.com/qutebrowser/qutebrowser.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

pylint: Remove now-unneeded suppressions 

The recent pytest 7.2 upgrade leads pylint to complain:

    ************* Module unit.browser.test_qutescheme
    tests/unit/browser/test_qutescheme.py:26:0: I0021: Useless suppression of 'no-name-in-module' (useless-suppression)
    tests/unit/browser/test_qutescheme.py:226:0: I0021: Useless suppression of 'no-member' (useless-suppression)

    ************* Module helpers.fixtures
    tests/helpers/fixtures.py:39:0: I0021: Useless suppression of 'no-name-in-module' (useless-suppression)
    tests/helpers/fixtures.py:639:0: I0021: Useless suppression of 'no-member' (useless-suppression)

possibly due to it not being able to infer 'py' anymore with the weird
shenanigans pytest does now?

Also, what weird glitch in the matrix is it that those just happen to be
on lines [2]26 and [6]39 for *both* files? 🤯
This commit is contained in:
Florian Bruhin 2022-11-08 17:02:30 +01:00
parent 2b86f66e48
commit 6e54962fe4
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/helpers/fixtures.py
View File

@ -36,7 +36,7 @@ import os.path
import dataclasses
import pytest
import py.path # pylint: disable=no-name-in-module
import py.path
from PyQt5.QtCore import QSize, Qt
from PyQt5.QtWidgets import QWidget, QHBoxLayout, QVBoxLayout
from PyQt5.QtNetwork import QNetworkCookieJar
@ -636,7 +636,7 @@ def redirect_webengine_data(data_tmpdir, monkeypatch):
def short_tmpdir():
"""A short temporary directory for a XDG_RUNTIME_DIR."""
with tempfile.TemporaryDirectory() as tdir:
yield py.path.local(tdir) # pylint: disable=no-member
yield py.path.local(tdir)
class ModelValidator:

4
tests/unit/browser/test_qutescheme.py
View File

@ -23,7 +23,7 @@ import os
import time
import logging
import py.path # pylint: disable=no-name-in-module
import py.path
from PyQt5.QtCore import QUrl, QUrlQuery
import pytest
@ -223,7 +223,7 @@ class TestPDFJSHandler:
@pytest.fixture
def download_tmpdir(self):
tdir = downloads.temp_download_manager.get_tmpdir()
yield py.path.local(tdir.name) # pylint: disable=no-member
yield py.path.local(tdir.name)
tdir.cleanup()
def test_existing_resource(self):