mirror
/
qutebrowser
mirror of https://github.com/qutebrowser/qutebrowser.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve code style, grammar and a docstring

This commit is contained in:
arza 2025-07-03 22:10:26 +03:00
parent 5d33d20d0c
commit 5048eac9e8
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
qutebrowser/browser/downloads.py
View File

@ -493,11 +493,7 @@ class AbstractDownloadItem(QObject):
total=total, errmsg=errmsg)) total=total, errmsg=errmsg))
def _find_next_filename(self) -> None: def _find_next_filename(self) -> None:
"""Append unique numeric suffix to filename. """Append unique numeric suffix to filename and rerun _set_filename."""
After finding a unique filename, restart the process of setting the
filename which will update the filename shown in the downloads list.
"""
assert self._filename is not None assert self._filename is not None
path, file = os.path.split(self._filename) path, file = os.path.split(self._filename)
# Pull out filename extension which could be a two part one like # Pull out filename extension which could be a two part one like
@ -511,9 +507,9 @@ class AbstractDownloadItem(QObject):
suffix = '' suffix = ''
for i in range(2, 1000): for i in range(2, 1000):
self._filename = os.path.join(path, f'{base}_{i}{suffix}') filename = os.path.join(path, f'{base}_{i}{suffix}')
if not (os.path.exists(self._filename) or self._get_conflicting_download()): if not (os.path.exists(filename) or self._get_conflicting_download()):
self._set_filename(self._filename) self._set_filename(filename)
break break
else: else:
self._die('Alternative filename not available.') self._die('Alternative filename not available.')
@ -776,7 +772,7 @@ class AbstractDownloadItem(QObject):
elif os.path.isfile(self._filename): elif os.path.isfile(self._filename):
# The file already exists, so ask the user if it should be # The file already exists, so ask the user if it should be
# overwritten. # overwritten.
txt = "<b>{}</b> already exists. Overwrite? (\"No\" renames)".format( txt = "<b>{}</b> already exists. Overwrite? (\"No\" renames.)".format(
html.escape(self._filename)) html.escape(self._filename))
self._ask_confirm_question("Overwrite existing file?", txt, self._ask_confirm_question("Overwrite existing file?", txt,
custom_no_action=self._find_next_filename) custom_no_action=self._find_next_filename)