Make qute://start search work with QtWebEngine 6.3+
Until we look at #7220 proper (thus splitting this into a qute-start:// which could probably have more permissions to do remote requests), we'll need to do with somewhat of a hack to allow this even if QtWebEngine does not. Given the very limited scope (only from qute://start, only opening the search engine URL, only with a form submitted request), this should be acceptable without compromsing security in any way. Fixes #7790
This commit is contained in:
parent
8defe1ae44
commit
216a9f9a9b
|
|
@ -30,7 +30,7 @@ if TYPE_CHECKING:
|
|||
from qutebrowser.keyinput import modeman
|
||||
from qutebrowser.config import config, websettings
|
||||
from qutebrowser.utils import (utils, objreg, usertypes, log, qtutils,
|
||||
urlutils, message, jinja)
|
||||
urlutils, message, jinja, version)
|
||||
from qutebrowser.misc import miscwidgets, objects, sessions
|
||||
from qutebrowser.browser import eventfilter, inspector
|
||||
from qutebrowser.qt import sip
|
||||
|
|
@ -1169,6 +1169,23 @@ class AbstractTab(QWidget):
|
|||
navigation.url.errorString()))
|
||||
navigation.accepted = False
|
||||
|
||||
# WORKAROUND for QtWebEngine >= 6.3 not allowing form requests from
|
||||
# qute:// to outside domains.
|
||||
if (
|
||||
self.url() == QUrl("qute://start/") and
|
||||
navigation.navigation_type == navigation.Type.form_submitted and
|
||||
navigation.url.matches(
|
||||
QUrl(config.val.url.searchengines['DEFAULT']),
|
||||
QUrl.UrlFormattingOption.RemoveQuery) and
|
||||
objects.backend == usertypes.Backend.QtWebEngine and
|
||||
version.qtwebengine_versions().webengine >= utils.VersionNumber(6, 3)
|
||||
):
|
||||
log.webview.debug(
|
||||
"Working around qute://start loading issue for "
|
||||
f"{navigation.url.toDisplayString()}")
|
||||
navigation.accepted = False
|
||||
self.load_url(navigation.url)
|
||||
|
||||
@pyqtSlot(bool)
|
||||
def _on_load_finished(self, ok: bool) -> None:
|
||||
assert self._widget is not None
|
||||
|
|
|
|||
Loading…
Reference in New Issue