mirror
/
qutebrowser
mirror of https://github.com/qutebrowser/qutebrowser.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Re-enable renderer process tests on Qt 5.14 

QTBUG-80085 has been fixed.
This mostly reverts d8745237d9.
See #5013
This commit is contained in:
Florian Bruhin 2019-12-09 00:38:10 +01:00
parent 784c55bb85
commit 02c3f02edc
3 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pytest.ini
View File

@ -27,7 +27,6 @@ markers =
this: Used to mark tests during development
no_invalid_lines: Don't fail on unparseable lines in end2end tests
qtbug60673: Tests which are broken if the conversion from orange selection to real selection is flaky
qtbug80085: Tests which are broken on Qt 5.14 due to a missing renderProcessTerminated signal
fake_os: Fake utils.is_* to a fake operating system
unicode_locale: Tests which need an unicode locale to work
qtwebkit6021_xfail: Tests which would fail on WebKit version 602.1

6
tests/conftest.py
View File

@ -108,12 +108,6 @@ def _apply_platform_markers(config, item):
config.webengine,
"Broken on webengine due to "
"https://bugreports.qt.io/browse/QTBUG-60673"),
('qtbug80085',
pytest.mark.xfail,
qtutils.version_check('5.14', compiled=False) and
config.webengine,
"Broken on webengine due to "
"https://bugreports.qt.io/browse/QTBUG-80085"),
('qtwebkit6021_xfail',
pytest.mark.xfail,
version.qWebKitVersion and # type: ignore

6
tests/end2end/features/misc.feature
View File

@ -514,20 +514,20 @@ Feature: Various utility commands.
Then the error "Renderer process was killed" should be shown
# Skipped on Windows as "... has stopped working" hangs.
@qtwebkit_skip @no_invalid_lines @posix @qt>=5.9 @qtbug80085
@qtwebkit_skip @no_invalid_lines @posix @qt>=5.9
Scenario: Renderer crash (5.9)
When I run :open -t chrome://crash
Then "Renderer process crashed" should be logged
And "* 'Error loading chrome://crash/'" should be logged
@qtwebkit_skip @no_invalid_lines @qt>=5.9 @flaky @qtbug80085
@qtwebkit_skip @no_invalid_lines @qt>=5.9 @flaky
Scenario: Renderer kill (5.9)
When I run :open -t chrome://kill
Then "Renderer process was killed" should be logged
And "* 'Error loading chrome://kill/'" should be logged
# https://github.com/qutebrowser/qutebrowser/issues/2290
@qtwebkit_skip @no_invalid_lines @flaky @qtbug80085
@qtwebkit_skip @no_invalid_lines @flaky
Scenario: Navigating to URL after renderer process is gone
When I run :tab-only
And I open data/numbers/1.txt