mirror
/
plugin-update-checker
mirror of https://github.com/YahnisElsts/plugin-update-checker.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify a couple of conditions. 

In theory, $state and $state->update should always be either NULL or objects. That means isset() fully covers the possibilities and we don't need the additional empty() checks.
This commit is contained in:
Yahnis Elsts 2016-03-24 22:27:20 +02:00
parent 7a1f6d90ab
commit b973ad6452
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
plugin-update-checker.php
View File

@ -353,7 +353,7 @@ class PluginUpdateChecker_3_0 {
$state = null;
}
if ( !empty($state) && isset($state->update) && is_object($state->update) ){
if ( isset($state, $state->update) && is_object($state->update) ) {
$state->update = PluginUpdate_3_0::fromObject($state->update);
}
return $state;
@ -594,8 +594,8 @@ class PluginUpdateChecker_3_0 {
public function getUpdate() {
$state = $this->getUpdateState(); /** @var StdClass $state */
//Is there an update available insert?
if ( !empty($state) && isset($state->update) && !empty($state->update) ){
//Is there an update available?
if ( isset($state, $state->update) ) {
$update = $state->update;
//Check if the update is actually newer than the currently installed version.
$installedVersion = $this->getInstalledVersion();