mirror
/
plugin-update-checker
mirror of https://github.com/YahnisElsts/plugin-update-checker.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Ensure the update (if there is one) shows up right away when the user clicks "Check for updates". Prior to this change they would need to reload the page to see the update. 

Cause: Originally the update check routine was attached to the admin_notices hook. However, the plugin list is populated long before that action. 

Fixed by running the update check earlier in the request process and redirecting back to plugins.php to display the success message. As a side-effect, this will also prevent unwanted extra checks when the user reloads the page.
This commit is contained in:
Yahnis Elsts 2012-10-20 16:54:32 +00:00
parent 80a644e329
commit 850a0f18be
1 changed files with 23 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
plugin-update-checker.php
View File

@ -74,7 +74,8 @@ class PluginUpdateChecker {
add_filter('transient_update_plugins', array($this,'injectUpdate')); //WP 2.8+
add_filter('plugin_row_meta', array($this, 'addCheckForUpdatesLink'), 10, 4);
add_action('admin_notices', array($this, 'handleManualUpdateCheck'));
add_action('admin_init', array($this, 'handleManualCheck'));
add_action('admin_notices', array($this, 'displayManualCheckResult'));
//Set up the periodic update checks
$this->cronHook = 'check_plugin_updates-' . $this->slug;
@ -419,12 +420,11 @@ class PluginUpdateChecker {
/**
* Check for updates when the user clicks the "Check for updates" link.
*
* You can change the result message by using the "puc_manual_check_message-$slug" filter.
* @see self::addCheckForUpdatesLink()
*
* @return void
*/
public function handleManualUpdateCheck() {
public function handleManualCheck() {
$shouldCheck =
isset($_GET['puc_check_for_updates'])
&& $_GET['puc_check_for_updates'] == $this->slug
@ -433,16 +433,31 @@ class PluginUpdateChecker {
if ( $shouldCheck ) {
$update = $this->checkForUpdates();
if ( $update === null ) {
$status = ($update === null) ? 'no_update' : 'update_available';
wp_redirect(add_query_arg('puc_update_check_result', $status, admin_url('plugins.php')));
}
}
/**
* Display the results of a manual update check.
* @see self::handleManualCheck()
*
* You can change the result message by using the "puc_manual_check_message-$slug" filter.
*/
public function displayManualCheckResult() {
if ( isset($_GET['puc_update_check_result']) ) {
$status = strval($_GET['puc_update_check_result']);
if ( $status == 'no_update' ) {
$message = 'This plugin is up to date.';
} else {
} else if ( $status == 'update_available' ) {
$message = 'A new version of this plugin is available.';
} else {
$message = sprintf('Unknown update checker status "%s"', htmlentities($status));
}
printf(
'<div class="updated"><p>%s</p></div>',
apply_filters('puc_manual_check_message-' . $this->slug, $message, $update)
apply_filters('puc_manual_check_message-' . $this->slug, $message, $status)
);
//todo: the update doesn't show up right away, why?
}
}