[web] interviews/navbar: tweak bottom border appearance
This commit is contained in:
parent
614ca7efef
commit
b2263dae81
|
|
@ -9,7 +9,7 @@ export default function FooterlessLayout({ children }: Props) {
|
|||
return (
|
||||
<>
|
||||
<GlobalBannerInterviews />
|
||||
<InterviewsNavbar showBottomBorderOnScroll={false} />
|
||||
<InterviewsNavbar />
|
||||
{children}
|
||||
</>
|
||||
);
|
||||
|
|
|
|||
|
|
@ -15,7 +15,7 @@ export default function InterviewsMarketingLayout({ children }: Props) {
|
|||
<FeedbackWidget />
|
||||
<GlobalBannerInterviews />
|
||||
<div className="flex min-h-screen flex-col">
|
||||
<InterviewsNavbar />
|
||||
<InterviewsNavbar bottomBorder={false} />
|
||||
<div className="grow">{children}</div>
|
||||
<Section>
|
||||
<InterviewsFooter />
|
||||
|
|
|
|||
|
|
@ -88,7 +88,7 @@ export default function NavProductDropdownMenu({
|
|||
type="button">
|
||||
<Text
|
||||
color={variant === 'full' ? 'default' : 'secondary'}
|
||||
size="body2"
|
||||
size={variant === 'full' ? 'body2' : 'body3'}
|
||||
weight="bold">
|
||||
{label}
|
||||
</Text>
|
||||
|
|
|
|||
|
|
@ -31,13 +31,13 @@ import useInterviewsNavLinks from './useInterviewsNavLinks';
|
|||
import { useUser } from '@supabase/auth-helpers-react';
|
||||
|
||||
type Props = Readonly<{
|
||||
bottomBorder?: boolean;
|
||||
hideOnDesktop?: boolean;
|
||||
showBottomBorderOnScroll?: boolean;
|
||||
}>;
|
||||
|
||||
export default function InterviewsNavbar({
|
||||
bottomBorder = true,
|
||||
hideOnDesktop = false,
|
||||
showBottomBorderOnScroll = true,
|
||||
}: Props) {
|
||||
const { colorSchemePreference, setColorSchemePreference } =
|
||||
useColorSchemePreferences();
|
||||
|
|
@ -139,6 +139,7 @@ export default function InterviewsNavbar({
|
|||
return (
|
||||
<Navbar
|
||||
ref={navbarRef}
|
||||
bottomBorder={bottomBorder}
|
||||
endAddOnItems={<InterviewsNavbarEndAddOnItems />}
|
||||
hideOnDesktop={hideOnDesktop}
|
||||
isLoading={isUserProfileLoading}
|
||||
|
|
@ -152,7 +153,6 @@ export default function InterviewsNavbar({
|
|||
}
|
||||
mobileSidebarBottomItems={mobileSidebarBottomItems}
|
||||
renderMobileSidebarAddOnItems={renderMobileSidebarAddOnItems}
|
||||
showBottomBorderOnScroll={showBottomBorderOnScroll}
|
||||
translucent={!isSticky}
|
||||
/>
|
||||
);
|
||||
|
|
|
|||
|
|
@ -19,6 +19,7 @@ import type { NavbarTopLevelItem } from './NavTypes';
|
|||
import Button from '../Button';
|
||||
|
||||
type Props = Readonly<{
|
||||
bottomBorder?: boolean;
|
||||
className?: string;
|
||||
endAddOnItems?: React.ReactNode;
|
||||
hideOnDesktop?: boolean;
|
||||
|
|
@ -29,7 +30,6 @@ type Props = Readonly<{
|
|||
renderMobileSidebarAddOnItems?: ({
|
||||
closeMobileNav,
|
||||
}: Readonly<{ closeMobileNav: () => void }>) => React.ReactNode;
|
||||
showBottomBorderOnScroll?: boolean;
|
||||
style?: CSSProperties;
|
||||
translucent?: boolean;
|
||||
unreadNotificationCount?: number;
|
||||
|
|
@ -47,7 +47,7 @@ function Navbar(
|
|||
translucent = false,
|
||||
hideOnDesktop = false,
|
||||
unreadNotificationCount = 0,
|
||||
showBottomBorderOnScroll,
|
||||
bottomBorder,
|
||||
}: Props,
|
||||
ref: React.Ref<HTMLDivElement>,
|
||||
) {
|
||||
|
|
@ -60,20 +60,21 @@ function Navbar(
|
|||
setIsMobileNavOpen(false);
|
||||
}
|
||||
|
||||
const showBottomBorder = showBottomBorderOnScroll ? translucent : true;
|
||||
|
||||
return (
|
||||
<div
|
||||
ref={ref}
|
||||
className={clsx(
|
||||
'z-fixed sticky top-[var(--banner-height)]',
|
||||
showBottomBorder && ['border-b', themeBorderColor],
|
||||
bottomBorder && ['border-b', themeBorderColor],
|
||||
translucent ? 'backdrop-blur' : 'bg-white dark:bg-neutral-900/60',
|
||||
'transition-[background-color]',
|
||||
hideOnDesktop && 'lg:hidden',
|
||||
className,
|
||||
)}>
|
||||
<NavbarHeightStyles hideOnDesktop={hideOnDesktop} />
|
||||
<NavbarHeightStyles
|
||||
hideOnDesktop={hideOnDesktop}
|
||||
borderHeight={bottomBorder ? 1 : 0}
|
||||
/>
|
||||
<div className="max-w-8xl mx-auto px-6">
|
||||
<div
|
||||
className={clsx(
|
||||
|
|
|
|||
Loading…
Reference in New Issue