diff --git a/apps/admin/src/app/api/conversions/route.ts b/apps/admin/src/app/api/conversions/route.ts index f37105635..34cfec548 100644 --- a/apps/admin/src/app/api/conversions/route.ts +++ b/apps/admin/src/app/api/conversions/route.ts @@ -62,7 +62,8 @@ WHERE created_at >= NOW() - INTERVAL '${daysBefore} days' GROUP BY date -ORDER BY date DESC;`; +ORDER BY + date DESC;`; const pgQueryEmailSignUps = `SELECT date_trunc('day', created_at AT TIME ZONE 'Asia/Singapore') AS date, diff --git a/apps/admin/src/components/ConversionsTable.tsx b/apps/admin/src/components/ConversionsTable.tsx index 94001d2bb..4bd764045 100644 --- a/apps/admin/src/components/ConversionsTable.tsx +++ b/apps/admin/src/components/ConversionsTable.tsx @@ -77,8 +77,10 @@ export default function ConversionsTable({ return { ...acc, [date]: { - confirmedEmailSignUps: Number(emailSignUpDay.confirmedEmailSignUps), - emailSignUps: Number(emailSignUpDay.emailSignUps), + confirmedEmailSignUps: Number( + emailSignUpDay?.confirmedEmailSignUps ?? 0, + ), + emailSignUps: Number(emailSignUpDay?.emailSignUps ?? 0), signUps: Number(signup.signUps), }, }; @@ -270,7 +272,7 @@ export default function ConversionsTable({ description: 'Number of users who have email as their primary sign up method but did not verify (on that day) out of users who signed up using email', getValue: (_row, signUp) => - signUp && signUp.signUps > 0 + signUp && signUp.emailSignUps > 0 ? `${((signUp.confirmedEmailSignUps / signUp.emailSignUps) * 100).toFixed(2)}%` : '-', header: 'Email verification rate',