Commit Graph

441 Commits

Author SHA1 Message Date
jrfnl 19fb4e2727
PHPCS/PHPCompatibility: favour inline ignores over blanket rule excludes
Best practice tweak regarding the use of PHPCompatibility.

It is strongly recommended to use inline ignore annotations when a reported issue is not a problem (because it is accompanied by a `function_exists()`, `defined()` or other check), instead of excluding a rule completely via the ruleset.

Blanket code-base wide ignores mean that:
* ... if a PR introduces new code (or changes existing code) which uses a non-cross-version compatible PHP feature...
* ... and the code doesn't have the right safeguards in place for cross-version compatibility...
* ... PHPCompatibility would not flag it because of the codebase wide ignore...
* ... which could cause problems for the end-users.

Selective, inline ignores ensure that only the annotated error is ignored and only for that specific bit of code, preventing the above described problem.

It also means that when something changes in PHP - like a deprecated method being removed -, you will be notified about the issue again so you can review if the current cross-version compatibility tweak is still the most optimal one.
2025-11-23 05:23:36 +01:00
Marcus Bointon 8bc8f15714
Merge changes from 7.0.0 2025-10-15 19:01:45 +02:00
Marcus Bointon 54b2ab00d3
Fix $cid assembly 2025-10-06 09:21:07 +02:00
Marcus Bointon c09730a7d7
CS 2025-10-06 09:10:51 +02:00
Mariusz Krzaczkowski 306ea7022f
Update PHPMailer.php 2025-10-06 09:10:51 +02:00
Mariusz Krzaczkowski 9489d4c5c3
Update PHPMailer.php 2025-10-06 09:10:51 +02:00
Mariusz Krzaczkowski 2e38fff8f3
Add cid default domain 2025-10-06 09:10:51 +02:00
Mariusz Krzaczkowski 9a5f46f747
Add cid default domain 2025-10-06 09:10:51 +02:00
SirLouen 0b6ed12ed3
Adding new Translation format proposed by @Synchro 2025-09-30 17:24:11 +02:00
SirLouen 817d1e604e
Forgot one 2025-09-30 14:52:07 +02:00
SirLouen 94f8565fd0
Improving docs and translations for deprecated useimap 2025-09-30 14:48:13 +02:00
Marcus Bointon d9e3b36b47
6.11.1 2025-09-30 13:54:53 +02:00
SirLouen 29f48d454e
Regressing deprecatedArg 2025-09-30 13:21:53 +02:00
Marcus Bointon 9500c37b70
Version and changelog 2025-09-29 18:40:59 +02:00
Marcus Bointon 39a1bc905c
Merge pull request #3237 from SirLouen/patch/3234
Reply-To to Indexed Array Conversion
2025-09-29 18:28:02 +02:00
SirLouen bcc4d84893
Reply-To to Indexed Array Conversion 2025-09-26 22:05:05 +02:00
SirLouen b0f96abda0
Next version will be 6.11.0 for this deprecatedArg 2025-09-26 17:17:09 +02:00
SirLouen 0d5d8854f9
Fixing 8.3+ mb_decode_mimeheader changes 2025-09-26 17:13:11 +02:00
SirLouen b1860a4e86
Better using static 2025-09-26 01:22:41 +02:00
SirLouen f4d321633d
Taking advantage of the new static translator 2025-09-26 01:16:38 +02:00
SirLouen 95ff455f9d
Adding #3235 and reorganizing tests 2025-09-26 01:07:01 +02:00
Manuel Camargo 6cab1544fa
Merge branch 'master' into patch/3201 2025-09-12 13:41:55 +02:00
Georg Sieber fd9f8d33cb
fix encoding header for SMIME signed messages with long lines 2025-09-11 19:03:20 +02:00
Manuel Camargo 6a6e66abf4
Merge branch 'master' into patch/3201 2025-09-11 14:42:41 +02:00
SirLouen b1b1f65f0b
Merge branch 'master' into patch/3201 2025-09-11 14:32:06 +02:00
SirLouen 3c93e8d6f3
Adding Temporary Specific Tests for Native Function 2025-08-24 16:03:51 +02:00
SirLouen e72170c6ba
Little separator line 2025-08-24 15:38:03 +02:00
SirLouen 69a2b8038f
Removing Tests. Reintroducing them fixed in #3197 2025-08-24 15:37:42 +02:00
SirLouen 0ce6905391
Merge branch 'master' into patch/3210 2025-08-24 15:29:04 +02:00
SirLouen 22885eaf4a
Preparing new version for no-IMAP, Tests Pending 2025-08-23 16:40:10 +02:00
SirLouen b41dd255a2
Staticfying the Language Pack 2025-08-23 16:16:14 +02:00
SirLouen 34c6423ac6
Sorting the Array problem in doCallback 2025-08-22 17:19:27 +02:00
Marcus Bointon 19f17f8aeb
CS 2025-08-22 15:12:14 +02:00
Marcus Bointon da0cffbc05
CS 2025-08-21 10:23:38 +02:00
SirLouen 71dfc112c9
Better this deprecation method 2025-08-19 16:04:16 +02:00
SirLouen f1255a0a55
Deprecation & Composer Updates 2025-08-19 16:00:45 +02:00
SirLouen 97f4e58e18 Sorting the Array problem in doCallback 2025-08-17 13:18:53 +02:00
SirLouen f7b82634c9 Return useimap for BC 2025-08-17 12:28:52 +02:00
SirLouen 99b482752e Final Act including iconv_mime_decode 2025-08-17 00:01:46 +02:00
SirLouen d2fc22a4f1 Fixing #3204 2025-08-16 18:28:42 +02:00
SirLouen bf8e97d3c8 Adding Name Encoding Improvement without MbString Extension 2025-08-14 02:19:38 +02:00
Marcus Bointon f202f351ca
Don't use `-t` switch with qmail, see #3189 2025-08-08 11:58:13 +02:00
Marcus Bointon 912f278a48
Add workaround for #3163 2025-05-31 10:46:53 +02:00
Marcus Bointon bf74d75a1f
6.10.0 2025-04-24 17:19:31 +02:00
Marcus Bointon fc6779f050
Fail to add an address if it uses 8-bit chars in the domain, but we are missing extensions to support IDN. 2025-04-10 16:10:46 +02:00
Arnt Gulbrandsen d31cb27117
Adjust eai regex to disallow emoji and letters/numbers.
Update a few tests to match the recent changes.

Use the eai validator (unless another is being used) for addresses such as
info@müller-schmidt.de, for which PHPMailer may not choose to use SMTPUTF8.
2025-04-09 14:13:35 +02:00
Marcus Bointon b62de86fd2
Explain eai 2025-04-09 14:13:33 +02:00
Marcus Bointon eda0313e07
Explain eai 2025-04-09 14:13:30 +02:00
Marcus Bointon 17b3dfbdb9
Explain eai 2025-04-09 14:13:26 +02:00
Marcus Bointon 6467d54259
Explain why 2025-04-09 14:13:23 +02:00